javascript errors with event_livecomment

Found a bug? Tell us!!
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: javascript errors with event_livecomment

Post by onli »

This really makes a big difference. With specified path and cached javascript, there is almost no difference between having the plugin enabled or not at my local installation. Have a try with the path-option added to the attached plugin-version.

Garvin, can't we have a global place to store the outer plugin-path and solve this for all plugins? Or let a single simple script deliver the output of the files?
sincerely
Attachments
serendipity_event_livecomment-2.5.2.tar.gz
(33.75 KiB) Downloaded 283 times
stm999999999
Regular
Posts: 1531
Joined: Tue Mar 07, 2006 11:25 pm
Location: Berlin, Germany
Contact:

Re: javascript errors with event_livecomment

Post by stm999999999 »

onli wrote: Please try the attached versions of the plugins. The jQuery-Plugin now fetches the always up to date, minimized and gzipped version of jquery via the Google-API.
Is it a good idea - for performance and at all - to load something / a script from a foreign server?
Ciao, Stephan
stm999999999
Regular
Posts: 1531
Joined: Tue Mar 07, 2006 11:25 pm
Location: Berlin, Germany
Contact:

Re: javascript errors with event_livecomment

Post by stm999999999 »

onli wrote:This really makes a big difference. With specified path and cached javascript, there is almost no difference between having the plugin enabled or not at my local installation. Have a try with the path-option added to the attached plugin-version.
using the new jQuery and this newest livecomment ... nothing works at all!?

(using http://www.sankt-joseph-siemensstadt.de ... vecomment/ as manual plugin-path)
Ciao, Stephan
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: javascript errors with event_livecomment

Post by onli »

Is it a good idea - for performance and at all - to load something / a script from a foreign server?
That depends. If one's own server is faster than the foreign server can deliver the file it's a bad idea. But the Google-server is really fast and the jquery-file is smaller than the one delivered by the old version.

Additionally there is a valid chance that the file is already cached by the user even if he visits your page for the first time.

(will answer the second post after some experiments)
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: javascript errors with event_livecomment

Post by onli »

using the new jQuery and this newest livecomment ... nothing works at all!?
The version attached works for me. Two possibilities: 1. Something went wrong with the upload. 2. The footer-hook don't get executed.

I think it's the second one. Make sure that

Code: Select all

{serendipity_hookPlugin hook="frontend_footer"}
exists in the index.tpl of your template.
sincerely
stm999999999
Regular
Posts: 1531
Joined: Tue Mar 07, 2006 11:25 pm
Location: Berlin, Germany
Contact:

Re: javascript errors with event_livecomment

Post by stm999999999 »

oh yes, it haven't.

Now it works, it works fine. :D

only one little problem:

testing it on opera with elastic comment field, I get no border around the comment feld!? (w/o this option, no problem)
Ciao, Stephan
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: javascript errors with event_livecomment

Post by onli »

Glad it works fine :) Between one and two seconds loadtime, same for you? Does enabling the markup-Buttons increase the loadtime? It shouldn't.

The problem with elastic is known to me and I failed in fixing it myself. But thank you for mentioning it, the newest version seems to fix it. You can simply overwrite jquery.elastic.js with the one from the downloadpage.

Do you notice any more bugs?
stm999999999
Regular
Posts: 1531
Joined: Tue Mar 07, 2006 11:25 pm
Location: Berlin, Germany
Contact:

Re: javascript errors with event_livecomment

Post by stm999999999 »

it seems to work fine! :P Do you give the new code to sparatacus?

Thanks!
Ciao, Stephan
Post Reply