serendipity_plugin_linklist

Found a bug? Tell us!!
Post Reply
Alexander Heß
Regular
Posts: 7
Joined: Wed Jan 09, 2008 12:22 am
Location: Munich, Germany
Contact:

serendipity_plugin_linklist

Post by Alexander Heß »

Hi

I just recently set up a blog for a customer and since most customers don't speak XML I switched the plugin to use the "Manage Links" page.

My customer set up links which had query strings including the usual ampersands which made the links in the frontend view disappear.

Solution:

I added htmlentities() in functions add_link (line 460) and update_link (line 474) so these lines now are as follows:

Code: Select all

$values['link'] = htmlentities($link);
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: serendipity_plugin_linklist

Post by garvinhicking »

Hi!

Yes, the manage links interface requires you to add links in XHTML valid format. The problem is that we cannot easily add the patch you submitted because of two reasons:

1. It would break all existing links that people have entered in the plugin, so when they would update, those links would no longer work as they had a duplicate & in them.

2. I belive there once was a reason why we chose not not escape the default output. I believe it was done so that people could add special HTML markup code there, or it might be because with that the XML interface would no longer work... :-/

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply