Consistency: Static Page search results

[Don Chambers]

Hopefully someone has more time than I do for this......

I've recently noticed something when searching. When searching for "question", and perhaps I get a single hit for 1 entry, and also 1 static page, I will see this:

For entries, I get: "Your search for question returned 1 results:"

The word "question" is enclosed in <span class="searchterm">. The result number 1 is enclosed in <span class="searchresults">.... and for emphasis, I have made those bold in this example (which I - and others - often do in stylesheets)

For static pages, I get this: "Found 1 static pages:". Note the search term is not mentioned, and the number 1 is not wrapped in <span class="searchresults">.....

This is really pathetic that I am looking this closely, but I wonder if these should be consistent.... meaning, give the staticpage_result_header the same text as exists for entries...... The text does not have to be identical, in fact, I think that static page results should continue to say "x static page(s)"... but perhaps it could also have the search term referenced, and place that, and the result count in the same span class? And instead of "found" it could be prefaced by the same "Your search for..."?

I know we have more pressing issues, but I thought this could be a nice fix for 1.4 while we are still in beta.

[sonichouse]

I've recently noticed something when searching. When searching for "question", and perhaps I get a single hit for 1 entry, and also 1 static page, I will see this:

For entries, I get: "Your search for question returned 1 results:"
.....
For static pages, I get this: "Found 1 static pages:". Note the search term is not mentioned, and the number 1 is not wrapped in <span class="searchresults">.....

I am not convinced that the end user is really concerned whether the term is in a static page or an entry.

Would returning a combined result be better ?

[garvinhicking]

Hi!

This is solely related to the staticpage plugin, it has no dependencies on the 1.4 beta (so iit can be fixed independently from it).

For consistency, I also think that this could be added to the staticpage search output.

Would returning a combined result be better ?

Sadly the results cannot be combined, as they are two different result sets.

Regards,
Garvin