Bug in Dev.Version with author and authorid

[konus]

Hello,
I use the nightly snapshot from 15 Sep 08 and I found the following problem:
Every entry I save (a new one ore a edited old one) gets in the database ( serendipity_entries) the value "1" for author and "0" for authorid.

Its even not possible to set the author with the extended properties plugin.

Background Information: I am logged in as administrator. I have 2 entrys in serendipity_authors. authorid "1" (thats me whith author="konus") and authorid "2" (thats an empty user without any rights.

Edit: After installation of extended properties plugin, my last entry had now the value "1" for author (instead of "konus") and "1" for authorid.

Second Edit: I made some havy edits on my post, I hope it is now much more understandable

[garvinhicking]

Hi!

I think this is because of a recent commit judebert made the the saving routine for showing previews. I have not yet had the chance to review that commit, I'll try to point him to this thread.

Many thanks for reporting.

Regards,
Garvin

[judebert]

I've reverted that portion, with a comment.

I wonder why Don didn't have trouble with it. Maybe he did, but just didn't notice?

For clarification: is the problem with the extended entry properties plugin, or with the core?

[konus]

I've reverted that portion, with a comment.

I wonder why Don didn't have trouble with it. Maybe he did, but just didn't notice?

For clarification: is the problem with the extended entry properties plugin, or with the core?

It is with the core. I only installed the extended entry properties plugin afterwards to test whether it could help. Maybe it is the reason why my autorid was now correct set to "1".

And I am not sure if the problem could make problems in real life. It seems, that for displaying the author name the authorid is resolved in s9y. I don't know, for what reason the author login-name ist saved addidionally to autorid in every entry. Is this redundant information?

I only found out, because I use an external script, which will connect to the database and extract all the geotag entries (for building the map) and this does not work anymore (because of this little problem).

Greetings Konus

[garvinhicking]

Hi!

Yes, "author" is redundant information from older s9y versions. But there were too many dependencies on that column, so it was not removed to let older plugins and parts of the core work properly on the 'author' column...

HTH,
Garvin

[Don Chambers]

Jude - is this the changes you did for previewing entries (ie, preview entries were missing certain fields/columns)? Is that still in tact following your revisions? Did you also change 1.3.x, or is that branch no longer worth maintaining?

[judebert]

Crap, I didn't think about the 1.3 branch. Thanks, Don.

Yes, this was part of the change I made for previewing entries. Your advanced template only needed one entry attribute; I attempted to populate them all, figuring future templates might need them. Obviously, the entry's author need not be the author currently examining the entry; when I set that to $serendipity['user'], it was saved along with the entry.

I took out the author and number of comments attributes that weren't needed, but left your change intact. I'm going back to update the 1.3 branch now.

[Don Chambers]

Understood Judebert. Thanks.