New Template

[reinhardl]

Hi,
here is Multicolor a mix of my favorit templates like mimbo and wppremium and many tips from the forum.

comments welcome

[yellowled]

Multicolor a mix of my favorit templates like mimbo and wppremium and many tips from the forum.

comments welcome

Okay, first of all: Whoa! This must have been quite an effort to pull off, way to go.

Some comments on the backend/theme options:

* Your UTF-8 lang files actually are in ISO-8859-1, which means I don't get to see German umlauts in the theme options.
* I think you should either arrange the RSS icons in the same order as they are listed in the select box or vice versa, otherwise you'll confuse users.
* MY_ADDTHIS_ACCOUNT needs to be assigned some text, at least in the German UTF-8 file.
* The "help" link doesn't work, it's displayed in code in the theme options, not as an actual link.
* WANT_ADSENSE lacks a description text, too.
* You'll maybe want to use the patch for the configurable navbar that Abdussammad provided somewhere here in the forums so the theme options don't have to be reloaded if users change the number of links. Feel free to email me for that patch if you can't find it in the forums.

Let's see for the frontend, although I have barely seen half of it's variants:

* First of all, there's minimal horizontal scrolling in a 1024x768 Firefox 3. I guess 975px for the container is just a tad too much, maybe ... no, hold on, that's not it ... well, I can't figure it out on the fly, but something makes this a tad too wide for 1024x768.
* I think you forgot to style the categories sidebar plugin. Might depend on the colorset. I'm currently looking at the default, and I can't even read it. Same for the related tags tag cloud. (This might be because I'm using 1.4 beta which already used the updated plugin styles. So maybe I'm wrong with some of the plugins.)
* Same for blockquotes. Might be because I use <blockquote><p>...</p></blockquote> in my dev blog, but that's the way it should be used as far as I know.
* Tags in the entry footer could use some styling, including link colors there. Same for related links which are inserted by the freetag plugin.
* I don't think you meant to leave images from the media database unstyled altogether; they're not even floated, which makes giving them an, erm, orientation in the media database pretty pointless.
* I think select boxes (in the sidebar as well as in the content area, i.e. comment form) are a way too wide.
* Maybe it's my old monitor, but I can barely read comments made by the entry's author.
* Same for the send/preview buttons in the comment form. And for the labels in the contact form.

Don't get me wrong - it's still a great template and a humongous effort. I still have to figure out and test a lot of the theme options. Kudos, really.

But it seems like this still needs some work, you've been a little sloppy here and there

YL

[reinhardl]

ok I will work on it ...

[reinhardl]

@yellowled

forgot to style the categories sidebar plugin

???

My sandbox

[yellowled]

forgot to style the categories sidebar plugin

???

My sandbox

Well, it does look fine in that particular colorset. I was looking at the black colorset in blog layout, and it looked, well, about the same I'd say, but in the context of the black colorset it was barely readable.

I have to check it again, maybe it was my old monitor fooling me. (Got a new one in the meantime.)

YL

[Don Chambers]

* You'll maybe want to use the patch for the configurable navbar that Abdussammad provided somewhere here in the forums so the theme options don't have to be reloaded if users change the number of links. Feel free to email me for that patch if you can't find it in the forums.

I thought that had a security risk, or am I thinking of something else?

[yellowled]

* You'll maybe want to use the patch for the configurable navbar that Abdussammad provided somewhere here in the forums so the theme options don't have to be reloaded if users change the number of links. Feel free to email me for that patch if you can't find it in the forums.

I thought that had a security risk, or am I thinking of something else?

It did, but Abdussammad has since revised it, and I think he also posted that version here, didn't he?

YL

[Don Chambers]

It did, but Abdussammad has since revised it, and I think he also posted that version here, didn't he?

YL

I cannot barely remember what I did yesterday, so I certainly cannot remember any revised code for this! I'll try to search for it in a while, but if you happen to beat me to it, do me a favor and post a link to the post.

[sonichouse]

It did, but Abdussammad has since revised it, and I think he also posted that version here, didn't he?

YL

I cannot barely remember what I did yesterday, so I certainly cannot remember any revised code for this! I'll try to search for it in a while, but if you happen to beat me to it, do me a favor and post a link to the post.

How about here ?

[Don Chambers]

That's the post sonichouse - thanks.... and it was also the security issue I was vaguely remembering. It looks like it was resolved by a combination of a s9y patch by Garvin, and a code change by Abdussammad.

It arose out of a discussion regarding Yellowled's port "Gossip City". Many templates, like that port, offer a configurable navbar permitting the user to specify the number of navbar items. The typical code, however, seems to require the user to reload the "manage styles" page if they change the number of links and then save their changes. Abdussammad's code (I have not yet tried it) suggests this would not be necessary with a minor code change:

From this:

Code: Select all

$template_loaded_config = serendipity_loadThemeOptions($template_config, $serendipity['smarty_vars']['template_option']);

to this:

Code: Select all

$template_loaded_config = serendipity_loadThemeOptions($template_config, $serendipity['smarty_vars']['template_option']);
if(isset($_POST['serendipity']['template']['amount']) && serendipity_userLoggedIn() && serendipity_checkPermission('adminTemplates'))
	{
		$temp_post=$_POST['serendipity']['template']['amount'];
			if(is_numeric($temp_post))
				$template_loaded_config['amount'] =$temp_post;
		
	}

It does not appear that Yellowled incorporated this change into the Gossip City port.

@YL - are you using this code in any of your templates?

[sonichouse]

That's the post sonichouse - thanks.... and it was also the security issue I was vaguely remembering. It looks like it was resolved by a combination of a s9y patch by Garvin, and a code change by Abdussammad.

No problem, it was only a search away

I love the idea of the tabs for search/archives/categories this reclaims a huge amount of real estate.

[yellowled]

It looks like it was resolved by a combination of a s9y patch by Garvin, and a code change by Abdussammad.

It doesn't just look like that

The typical code, however, seems to require the user to reload the "manage styles" page if they change the number of links and then save their changes.

Dude, are you kiddin' me? We have that old code in BP!

It does not appear that Yellowled incorporated this change into the Gossip City port.

Nope. Sheer laziness

are you using this code in any of your templates?

Yes, but not in a public one (so far). I'm too lazy to update the older templates.

YL

[Don Chambers]

I know the earlier version is in bp!!! I'm not THAT far gone!!! ...

..... yet!!!