Plugin mycalendar - rss-feed without title

Found a bug? Tell us!!
Post Reply
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

Plugin mycalendar - rss-feed without title

Post by konus »

Hello,
I just started using the fine mycalendar-plugin. After subscribing to my own mycalendar-rss-feed I noticed, that the Feed-name was empty. I think I found a small bug.

at line 406

Code: Select all

    <title><?php $serendipity['blog_title']; ?></title>
and at line 416

Code: Select all

    <author><?php echo $serendipity['blog_title']; ?></author>
I changed $serendipity['blog_title'] to $serendipity['blogTitle'] and now everything works fine.

One more feature request: Because it is now difficult to distinct between the normal feed and the mycalenar-feed I would like to suggest to add to 'blogTitle' the name of the box in the sidebar, which can be set in plugin configuration. At the moment I am doing this in the code in this way:

Code: Select all

    <title><?php echo $serendipity['blogTitle']; ?> - Termine</title>
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Plugin mycalendar - rss-feed without title

Post by garvinhicking »

Hi!

Good catch, I committed your fix. I now simply appended the plugin title to the feed name. Getting the sidebar plugin configuration inside the event plugin is not so straightforward, so I didn't have time yet to check into this. For the time being, the "My Calendar" addition should also help a bit at least :)

Thanks,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply