Bug in freeTag event plugin

[WebComPas]

Hello!

Recently I noticed a bug in the freeTag event plugin. It's not an evil bug but I would be glad if it was fixed. By the way, it could be fixed very easyly.
In the tag list within the entry edit form the tags are ordered by their first letter. If there are tags, which have the same first letter but in lower case and upper case, the group showing letter is displayed more than once. So it looks for example like this:

|N: Nagios, |O: Office, |O: openSource, |O: Outlook, |P: PHP,

To fix this bug, it's only necessary to change lines 763 and766 in serendipity_event_freetag.php like that:

Code: Select all

// Original version:
if (substr($tag, 0, 1) != $lastletter)
[...]
$lastletter = substr($tag, 0, 1);


// Fixed version:
if (strtoupper(substr($tag, 0, 1)) != $lastletter)
[...]
$lastletter = strtoupper(substr($tag, 0, 1));

I hope this will be changed soon.


Pascal

[garvinhicking]

Hi!

Thanks a lot, a useful patch. I just committed it!

Regards,
Garvin