Hi
I wanted to be able to control which page is displayed after you've logged in or out. So have added a field to each of the event and login form plugin.
I've put a tar file at http://www.hospodaripomahajihospodarum. ... inform.tar
Neil
p.s If login fails it still redirects you... in my own app that login_url is only viewable if you are logged in, so not so much of a problem. I couldn't work out how to fix this if its possible.
I'ved modified event/plugin_loginform
-
garvinhicking
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: I'ved modified event/plugin_loginform
Hi!
Hm, the sidebar plugin references a $lougout_url which does not get set anywhere in code. So i removed that, and also removed in the event plugin some other references to not existing variables. Also, I made the URLs needed to be entered absolute (via http://blabla) so that the users have more flexibility to which page they want to redirect.
You can check out the commit I made in CVS:
http://php-blog.cvs.sourceforge.net/php ... p?view=log
http://php-blog.cvs.sourceforge.net/php ... p?view=log
Thanks a lot for your contribution, maybe in the future you have even more things to add. If possible, for the next patches, you could try to use 4 spaces instead of tabs for indenting the code, and also always use { and } indention even if optional, for better readability and so that it matches our coding guidelines.
Best regards,
Garvin
Hm, the sidebar plugin references a $lougout_url which does not get set anywhere in code. So i removed that, and also removed in the event plugin some other references to not existing variables. Also, I made the URLs needed to be entered absolute (via http://blabla) so that the users have more flexibility to which page they want to redirect.
You can check out the commit I made in CVS:
http://php-blog.cvs.sourceforge.net/php ... p?view=log
http://php-blog.cvs.sourceforge.net/php ... p?view=log
Thanks a lot for your contribution, maybe in the future you have even more things to add. If possible, for the next patches, you could try to use 4 spaces instead of tabs for indenting the code, and also always use { and } indention even if optional, for better readability and so that it matches our coding guidelines.
Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Hi!
>Hm, the sidebar plugin references a $lougout_url which does not get set >anywhere in code. So i removed that, and also removed in the event >plugin some other references to not existing variables.
Sorry about that I origionally only modified the sidebar plugin but found the even plugin also did redirection to homepage so moved the logout_url to the event plugin and didn't clean up.
>Also, I made the URLs needed to be entered absolute (via http://blabla) >so that the users have more flexibility to which page they want to >redirect.
I wanted to do that but thought it wouldn't work, that they need to reload the index.php etc.. I didnt' understand exactly how the login/out worked. But your change is great.
>Thanks a lot for your contribution, maybe in the future you have even >more things to add. If possible, for the next patches, you could try to use >4 spaces instead of tabs for indenting the code, and also always use { >and } indention even if optional, for better readability and so that it >matches our coding guidelines. Smile
Will do... thanks
Best regards
Neil
>Hm, the sidebar plugin references a $lougout_url which does not get set >anywhere in code. So i removed that, and also removed in the event >plugin some other references to not existing variables.
Sorry about that
I origionally only modified the sidebar plugin but found the even plugin also did redirection to homepage so moved the logout_url to the event plugin and didn't clean up.>Also, I made the URLs needed to be entered absolute (via http://blabla) >so that the users have more flexibility to which page they want to >redirect.
I wanted to do that but thought it wouldn't work, that they need to reload the index.php etc.. I didnt' understand exactly how the login/out worked. But your change is great.
>Thanks a lot for your contribution, maybe in the future you have even >more things to add. If possible, for the next patches, you could try to use >4 spaces instead of tabs for indenting the code, and also always use { >and } indention even if optional, for better readability and so that it >matches our coding guidelines. Smile
Will do... thanks
Best regards
Neil