quickblog.tpl question

Creating and modifying plugins.
Post Reply
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: quickblog.tpl question

Post by garvinhicking »

Hi!

Yes, copying it to your template directory is preferable.

jhead is a command line tool like imagemagick; if it exists (and is in your $PATH) it will be used automatically, if you enabled the config option of the plugin.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Exactly that option, yes. Is jhead executable for your PHP? Is your PHP allowed to call external commands? (SafeMode blocks this...)

You might want to patch the PHP file to see where jhead is called and see if that produces valid output?
Also I discovered a "bug". If you use the quickblog action, it created a filename.quickblog.jpg intermediate sized file. When you use the media manager after to delete the filename.jpg, it erases the file, the thumbnail, but leaves the filename.quickblog.jpg file sitting in the directory
Ah, yes. The plugin should check for those files upon removal, this needs fixing.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

The preference of the PHP function is actually somewhat different; It's easier to detect if PHP is available than checking $PATH if you have jhead, and even then your provider might block external PHP commands.

So if jhead were preferred, the majority of servers (which do not have jhead) will first run a non existing programm, maybe spew out an error, and only then would use the existing PHP option.

I think the better way for this would be to set the preference of this through a seperate configuration option for the plugin. I'm currently lacking time to implement that, but I'll see if I find time for this the next week. Of course, patches are also appreciated ;)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Yea, just Easter got inbetween. I'll commit your patch the next days!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Post by Don Chambers »

Rob - your posts did not come off as pushy, and - while not wanting to put words into Garvin's mouth - I seriously doubt if he took it that way!!!

Keep up the great job of making contributions where you can!!!! This is a community afterall, and we all benefit from improvements such as you have suggested!!! :wink:
=Don=
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Post by Don Chambers »

Rob - your contributions are well known by those that pay attention to such things, myself included!!!!!!!!! In fact, you keep up this great work, and I might well be asking YOU for help since php isn't my expertise!!! :lol:
=Don=
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

No pushing felt here across the ocean :)

All is well, and many thanks for your contribution, just like Don already gave you in advance *g*

Read: Just committed :)

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply