Ported: i3theme

Skinning and designing Serendipity (CSS, HTML, Smarty)
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Ported: i3theme

Post by yellowled »

Yeah, well, it's me again :wink:

As sort of a request by someone who has earned the right to request a theme port because of his contributions to our little blog engine (Guess who?), I have ported i3theme, a very special template which enables users to move around the sidebar plugins of a blog using this template. It's also a Mac look design which would be perfect for any Mac-related blog :)

Details in my release announcement post (German and English available). This will be made available via spartacus, so you'll have to wait the usual 24-48 hours until it's actually available (unless you're lucky to have cvs access).

Porting this has been a lot of fun, using it also is. Hope you like it, too :)

YL
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Ported: i3theme

Post by garvinhicking »

Hi!

I love it, well done port. I'm thinking very hard on creating a blog where I can use this :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Wow, that's beautiful.

Of course, what else does one expect from a Mac theme?

It's also slow on my computer. The boxes try to rearrange themselves nicely, they slide around, but it's very jerky. And you can't move boxes between columns.

That doesn't make it very much less impressive. I've been wanting to do something like this for a while. Fantastic work!
Judebert
---
Website | Wishlist | PayPal
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

judebert wrote:It's also slow on my computer. The boxes try to rearrange themselves nicely, they slide around, but it's very jerky. And you can't move boxes between columns.
I think it depends on ... well, something :) It's pretty slow on my local Apache, too, but I got a short look at Garvin's dev blog via dyndns, and it seemed faster there. Maybe it depends on the number of sidebars, sidebar plugins, blog entries, browser ... no idea. Anyway, that's why I added an option to deactivate the javascript.
judebert wrote:That doesn't make it very much less impressive. I've been wanting to do something like this for a while. Fantastic work!
Thanks a lot :)

YL
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Ported: i3theme

Post by yellowled »

yellowled wrote:This will be made available via spartacus, so you'll have to wait the usual 24-48 hours until it's actually available
Just for the record: It is available via Spartacus now :)

YL
sonichouse
Regular
Posts: 196
Joined: Sun May 11, 2008 2:53 am
Contact:

Minor bug with feeds

Post by sonichouse »

Hi Yellowled,

I am a huge fan of your work, and am using i3theme currently.
I have just noticed that my feeds were broken, it looks like you need to add serendipityRewritePrefix to the feeds in index.tpl

Code: Select all

...
title="{$blogTitle} RSS feed" href="{$serendipityBaseURL}{$serendipityRewritePrefix}feeds/index.rss2" />
...
title="{$blogTitle} Atom feed"  href="{$serendipityBaseURL}{$serendipityRewritePrefix}feeds/atom.xml" />
These are defined in each of the sidebar blocks.

Thanks again for a great port :)
Steve is occasionally blogging here
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Minor bug with feeds

Post by yellowled »

sonichouse wrote:I have just noticed that my feeds were broken, it looks like you need to add serendipityRewritePrefix to the feeds in index.tpl

Code: Select all

...
title="{$blogTitle} RSS feed" href="{$serendipityBaseURL}{$serendipityRewritePrefix}feeds/index.rss2" />
...
title="{$blogTitle} Atom feed"  href="{$serendipityBaseURL}{$serendipityRewritePrefix}feeds/atom.xml" />
These are defined in each of the sidebar blocks.
Erm ... that is literally the code used to add those feeds in the index.tpl of the i3theme. Actually, this code is (or at least should be :wink:) used for that in any s9y template. Maybe you were using an older version of the theme before?

And what's this about the sidebar blocks? :? Elaborate, please. Maybe it's too late my time, but I don't get this.

YL
sonichouse
Regular
Posts: 196
Joined: Sun May 11, 2008 2:53 am
Contact:

Re: Minor bug with feeds

Post by sonichouse »

yellowled wrote:
sonichouse wrote:I have just noticed that my feeds were broken, it looks like you need to add serendipityRewritePrefix to the feeds in index.tpl

Code: Select all

...
title="{$blogTitle} RSS feed" href="{$serendipityBaseURL}{$serendipityRewritePrefix}feeds/index.rss2" />
...
title="{$blogTitle} Atom feed"  href="{$serendipityBaseURL}{$serendipityRewritePrefix}feeds/atom.xml" />
These are defined in each of the sidebar blocks.
Erm ... that is literally the code used to add those feeds in the index.tpl of the i3theme. Actually, this code is (or at least should be :wink:) used for that in any s9y template. Maybe you were using an older version of the theme before?

And what's this about the sidebar blocks? :? Elaborate, please. Maybe it's too late my time, but I don't get this.

YL
Sorry to confuse you, I may have an older version, but the meta block in the sidebar has

Code: Select all

{if $template_option.layout == 'ssb'}
        <div id="sidebar-right" class="dbx-group sidebar-right-ssb">
        {if $rightSidebarElements > 0}{serendipity_printSidebar side="right"}{/if}
            <div id="meta" class="dbx-box">
                <h3 class="dbx-handle">Meta</h3>

                <div class="dbx-content">
                    <ul>
                       <li class="rss"><a href="{$serendipityBaseURL}feeds/index.rss2">{$CONST.ENTRIES} (RSS)</a></li>
                       <li class="rss"><a href="{$serendipityBaseURL}feeds/comments.rss2">{$CONST.COMMENTS} (RSS)</a></li>
                       <li class="login"><a href="{$serendipityBaseURL}serendipity_admin.php">{$CONST.LOGIN}</a></li>
                   </ul>
                </div>
            </div><!-- /#meta -->
        </div><!-- /#sidebar-right -->
{/if}
[/size]
Steve is occasionally blogging here
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Minor bug with feeds

Post by yellowled »

sonichouse wrote:I may have an older version, but the meta block in the sidebar
Ah. Got it. I'll address this asap. Thanks for the feedback, Steve :)

YL
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Minor bug with feeds

Post by yellowled »

yellowled wrote:I'll address this asap.
Just for the record: Fixed.

YL
sonichouse
Regular
Posts: 196
Joined: Sun May 11, 2008 2:53 am
Contact:

XHTML issues

Post by sonichouse »

Hi YL,

I hope the trip to the salt mines was good, because I have a few minor issues for you :wink:.

In commentform.tpl

Code: Select all

<label for"email"><strong>{$CONST.EMAIL}</strong></label>
should be

Code: Select all

<label for="email"><strong>{$CONST.EMAIL}</strong></label>
and

Code: Select all

<p><textarea rows="10" cols="100%" id="serendipity_commentform_comment" name="serendipity[comment]" tabindex="4">{$commentform_data}</textarea>
           <br />
          {serendipity_hookPlugin hook="frontend_comment" data=$commentform_entry}<br /></p>
needs to change to stop the validator moaning about nesting divs inside <p> block

Code: Select all

<p><textarea rows="10" cols="100%" id="serendipity_commentform_comment" name="serendipity[comment]" tabindex="4">{$commentform_data}</textarea></p>
           <br />
        {serendipity_hookPlugin hook="frontend_comment" data=$commentform_entry}<br />

In entries.tpl to stop duplicate ID tags

Code: Select all

<a id="trackbacks"></a>
<h3 id="h3-trackbacks">{$entry.trackbacks} {$CONST.TRACKBACKS}</h3>
should be

Code: Select all

<a id="trackbacks"></a>
<h3 id="h3-trackbacks">{$entry.trackbacks} {$CONST.TRACKBACKS}</h3>
also

Code: Select all

<a id="comments"></a>
<h3 id="comments">{$entry.comments} {$CONST.COMMENTS}</h3>
should be

Code: Select all

<a id="comments"></a>
<h3 id="h3-comments">{$entry.comments} {$CONST.COMMENTS}</h3>
Steve is occasionally blogging here
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: XHTML issues

Post by yellowled »

sonichouse wrote:I hope the trip to the salt mines was good, because I have a few minor issues for you :wink:.
Are you kidding? I'm still in there! :wink:
sonichouse wrote:

Code: Select all

<label for="email"><strong>{$CONST.EMAIL}</strong></label>
Typo. Yay, and it was in plugin_contactform.tpl, too. Fixed and committed.
sonichouse wrote:In entries.tpl to stop duplicate ID tags

Code: Select all

<a id="trackbacks"></a>
<h3 id="h3-trackbacks">{$entry.trackbacks} {$CONST.TRACKBACKS}</h3>
should be

Code: Select all

<a id="trackbacks"></a>
<h3 id="h3-trackbacks">{$entry.trackbacks} {$CONST.TRACKBACKS}</h3>
Hm, that's gonna take a little longer because I'll also need to adapt the stylesheets for that.

Thanks again, Steve.

YL
sonichouse
Regular
Posts: 196
Joined: Sun May 11, 2008 2:53 am
Contact:

Re: XHTML issues

Post by sonichouse »

yellowled wrote:
sonichouse wrote:I hope the trip to the salt mines was good, because I have a few minor issues for you :wink:.
Are you kidding? I'm still in there! :wink:
sonichouse wrote:

Code: Select all

<label for="email"><strong>{$CONST.EMAIL}</strong></label>
Typo. Yay, and it was in plugin_contactform.tpl, too. Fixed and committed.
sonichouse wrote:In entries.tpl to stop duplicate ID tags

Code: Select all

<a id="trackbacks"></a>
<h3 id="h3-trackbacks">{$entry.trackbacks} {$CONST.TRACKBACKS}</h3>
should be

Code: Select all

<a id="trackbacks"></a>
<h3 id="h3-trackbacks">{$entry.trackbacks} {$CONST.TRACKBACKS}</h3>
Hm, that's gonna take a little longer because I'll also need to adapt the stylesheets for that.

Thanks again, Steve.

YL
Thanks, I was just about to post about the contact form, but you beat me to it :roll:

The trackback H3 is not styled, but I missed the comment H3 - thanks - changed locally.

The only warning I have is that the title does not translate & to & but it does for other pages. The error is from

Code: Select all

<title>Contact  - The life & grumbles of Steve Forster</title>
I am sure that the problem is with static pages, will dig a little further....

EDIT
The offending code is in serendipity_event_contactform.php

Code: Select all

if ($this->selected()) {
$serendipity['head_title']    = $this->get_config('pagetitle');
$serendipity['head_subtitle'] = htmlspecialchars($serendipity['blogTitle']);
}
break;
Just added htmlspecialchars() function around the blogTitle.
/EDIT
Steve is occasionally blogging here
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: XHTML issues

Post by yellowled »

sonichouse wrote:The trackback H3 is not styled, but I missed the comment H3 - thanks - changed locally.
Yes, it is. In s9y.css.

YL
sonichouse
Regular
Posts: 196
Joined: Sun May 11, 2008 2:53 am
Contact:

Re: XHTML issues

Post by sonichouse »

yellowled wrote:Yes, it is. In s9y.css.
:oops: Thanks.
Steve is occasionally blogging here
Post Reply