missing comment info after upgrade

Random stuff about serendipity. Discussion, Questions, Paraphernalia.
Post Reply
kmazy
Regular
Posts: 5
Joined: Tue Sep 05, 2006 7:13 pm

missing comment info after upgrade

Post by kmazy »

I have had my blog up for several years... Yesterday, I finally got up the nerve to upgrade. The upgrade went fairly smooth, However, now, I am missing the name and email, and the button to submit in the comments section. I don't know where to fix this... Can anyone help?

My blog is at http://scrapwarrior.com/blog/

Thanks,
Kris
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: missing comment info after upgrade

Post by garvinhicking »

Hi!

That seems odd, I believe there are language constant strings missing. Did you modify your custom template? Check the commentform.tpl file, maybe it is corrupted?

If you switch to a different template (temporarily) does it work then? If it doesn'T there as well, the main language file of yours might be corrupted through the upload!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Garvin, this corruption problem seems to happen regularly enough that we should consider doing something about it, if it's not too difficult.

Perhaps we could make a listing of files and their sha1 checksums, and check it during an upgrade? That way we can at least notify the user that their upload was corrupted.
Judebert
---
Website | Wishlist | PayPal
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

The problem is often FTP servers change ASCI encoding (\n to \r or \r\n) which changes the checksum, but not the validity of the files itself.

I agree that bad FTP uploading is a problem, but I'm not really sure on how to check that well enough...

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
kmazy
Regular
Posts: 5
Joined: Tue Sep 05, 2006 7:13 pm

Post by kmazy »

I changed it over to another template.... and the comments are working fine...

Looks like I need to "re-customize" this new template with my header now...

THANKS!!!
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Glad it worked for you!

Garvin, since ASCII mode only changes CR/LF and EOF, perhaps we could run a filter before hashing. This would take more time, but would warn the user when an error had occurred.

I had thought SHA1 ignored ASCII variations. I'm going to see if one of the other checksums does, instead.
Judebert
---
Website | Wishlist | PayPal
Post Reply