Infomation Mail on new comments

Random stuff about serendipity. Discussion, Questions, Paraphernalia.
Post Reply
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Infomation Mail on new comments

Post by blog.brockha.us »

Hello.

Today I received an email informing me about a new manualy added comment in my blog:
新回复已发表在网站 "Grischa", 在这个文章里面 "Internationale Funkausstellung (IFA) 2007"。
连接到文章: http://blog.brockha.us/index.php?/archi ... -2007.html

需要审核: 否
作者 IP 地址: 221.197.77.14
作者 名称: gogogo27
作者 电邮: an@email.com.cn
作者 网址: http://some-site.cn

回复:
Nice site..
Wishing you a Happy Sunday! Keep the articles coming!

----
你有以下选择:
浏览回复 -- http://blog.brockha.us/index.php?/archi ... .html#c613
删除回复 -- http://blog.brockha.us/index.php?/delet ... -2007.html

-- Grischa is powered by Serendipity. 最好的日志程序, 希望你喜欢它. 详情 <http://www.cexten.com> 得到更多支持...
The first thing I was suprised about was: Why is this mail written in the language of the commentor and not in the boards standard language?

The second thing: Why is this mail linking to cexten.com instead of s9y.org, as the other languages does? The link is found in the ZH and CN language files of the s9y standard installation. cexten.com looks somewhat dubious and is not related to s9y in any way. What is this?
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Infomation Mail on new comments

Post by garvinhicking »

Hi!

Yes, notification mails are sent in the users language, because technically the language constants loaded for that are the ones that the visitor executes. I don't think there's a way to do it differently, only by denying visitors to set their language.
The second thing: Why is this mail linking to cexten.com instead of s9y.org, as the other languages does? The link is found in the ZH and CN language files of the s9y standard installation. cexten.com looks somewhat dubious and is not related to s9y in any way. What is this?
Good catch. The chinese language maintainer always tried in the past to put his own links into the language file.

Sadly I can'T read chinese at all, and I need to have somebody who looks through the files to correct that. Deminy has offered to do so as soon as he finds time. :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: Infomation Mail on new comments

Post by blog.brockha.us »

Hi Garvin.
garvinhicking wrote:Yes, notification mails are sent in the users language, because technically the language constants loaded for that are the ones that the visitor executes. I don't think there's a way to do it differently, only by denying visitors to set their language.
But there is a default language configured for the blog, as far as I remember? Hmm.. How is constant loading working in php? If I reload another language file, will it override the old constants?
garvinhicking wrote:Good catch. The chinese language maintainer always tried in the past to put his own links into the language file.

Sadly I can'T read chinese at all, and I need to have somebody who looks through the files to correct that. Deminy has offered to do so as soon as he finds time. :)
Hmm.. I think even w/o understanding or beeing able to read chinese this link should be removed or replaced with the s9y link.. The link actualy found in the language file seems to be some adfarm or something.. This doesn't look very sincere having this link in the official language files.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Infomation Mail on new comments

Post by garvinhicking »

Hi!
But there is a default language configured for the blog, as far as I remember? Hmm.. How is constant loading working in php? If I reload another language file, will it override the old constants?
No, constants are loaded once and cannot be overwritten (that's why they're called constants in PHP *g*). So there's no way in the same http request to initialize a different language.

Constants perform better than variables, so we can't switch s9y to use variables (apart from that it would break BC).
Hmm.. I think even w/o understanding or beeing able to read chinese this link should be removed or replaced with the s9y link.. The link actualy found in the language file seems to be some adfarm or something.. This doesn't look very sincere having this link in the official language files.
Would you like to try to fix those links in 1.2 branch and trunk?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Post by blog.brockha.us »

I would just exchange the link with the s9y link, no matter what the text I can't read is saying. That should be easy to fix I hope.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Ah, you're right. Just did that. :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Post by blog.brockha.us »

Garvin.. You already did it? Don't tell me to do it, if you already did it. :lol:
I removed the special text from this lang entry too, as it seems to point to the other site only, too. (Comparing the entry with other lang entries)
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
deminy
Regular
Posts: 28
Joined: Mon Oct 10, 2005 6:17 am
Contact:

Post by deminy »

The Chinese language files used in S9Y v1.2 contain some problems. One problem is, one of the Chinese translators used his own website's link instead of S9Y's official link in at least one text.

I'm working on the Chinese translation now, and will go through all the texts. For the main language file, there are still more than 200 texts (out of around 800 texts) not properly translated/checked yet. Hopefully I will get it done soon.
Post Reply