Bulletproof: Problem with Amazon-Plugin

Skinning and designing Serendipity (CSS, HTML, Smarty)
Post Reply
iskru
Regular
Posts: 105
Joined: Thu Apr 19, 2007 9:39 pm

Bulletproof: Problem with Amazon-Plugin

Post by iskru »

Hi,

i just noticed that when i use the "Bulletproof" theme with S-S-B config and put the Amazon-Plugin in one of the sidebars, the post(s) / body gets out of place and drawn into the right sidebar at the end of the sidebar.

How to solve this issue?

Anybody else experiencing similar issues with other sidebar-plugs?
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Bulletproof: Problem with Amazon-Plugin

Post by yellowled »

iskru wrote:i just noticed that when i use the "Bulletproof" theme with S-S-B config and put the Amazon-Plugin in one of the sidebars, the post(s) / body gets out of place and drawn into the right sidebar at the end of the sidebar.

How to solve this issue?
URL to the blog where we can see the problem live?

YL
iskru
Regular
Posts: 105
Joined: Thu Apr 19, 2007 9:39 pm

Post by iskru »

You can see it at http://www.iskru.com/.

If i place the plug in the left sidebar, then it even chews up the right sidebar completely ...
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Bulletproof: Problem with Amazon-Plugin

Post by yellowled »

iskru wrote:i just noticed that when i use the "Bulletproof" theme with S-S-B config and put the Amazon-Plugin in one of the sidebars, the post(s) / body gets out of place and drawn into the right sidebar at the end of the sidebar.

How to solve this issue?
I have never used the Amazon sidebar plugin myself, but I'm guessing it's similar to a sidebar HTML nugget, i.e. you have to insert the code for the links into a textarea box in the plugin configuration? Because the code in your blog looks as if the div containers in the amazon box have not been closed properly, therefore closing other container divs used in BP.

Could you post the code you inserted into the amazon plugin?

YL
iskru
Regular
Posts: 105
Joined: Thu Apr 19, 2007 9:39 pm

Post by iskru »

No code needs to be inserted in the plugin. Just Amazon-Product-ID (ESINs / ISINs)

So perhaps the prob is the code of the plugin ...
d_cee
Regular
Posts: 603
Joined: Wed Jan 18, 2006 6:32 pm
Location: UK
Contact:

Post by d_cee »

Hi

There is indeed a </div> missing from the code in the plugin.

If you open serendipity_plugin_amazon.php in your code editor and look at line no 144

Code: Select all

echo "<div align='center'><a href='" . $article['url'] . "/" . $amazonid . "'>".$article['desc']."</a>";
it should be

Code: Select all

echo "<div align='center'><a href='" . $article['url'] . "/" . $amazonid . "'>".$article['desc']."</a></div>";
HTH

Dave
iskru
Regular
Posts: 105
Joined: Thu Apr 19, 2007 9:39 pm

Post by iskru »

Dave, thanks a lot.

But how could it happen that this plugin did make it to spartakus then?

I was assuming that if i download a plugin via spartakus, it's sort of quality approved or at least code checked ...
d_cee
Regular
Posts: 603
Joined: Wed Jan 18, 2006 6:32 pm
Location: UK
Contact:

Post by d_cee »

No problem

As for how the plugin had an error - these things happen I guess. I'm sure Garvin (or someone) will add the missing closing tag to the plugin so that it's OK for anyone else downloading it from spartacus in the future.

cheers

Dave
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

iskru wrote:I was assuming that if i download a plugin via spartakus, it's sort of quality approved or at least code checked ...
Surprise - developers are human, too :)

YL
chickens
Regular
Posts: 192
Joined: Wed Dec 06, 2006 12:15 am
Location: Vegas
Contact:

Post by chickens »

yellowled wrote:Surprise - developers are human, too :)

YL
I thought all programmers were robots who worked 24/7/365... I know that Garvin does :wink:
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

chickens wrote:I thought all programmers were robots who worked 24/7/365... I know that Garvin does :wink:
Actually, Garvin has got the 36-hour-day down, and I hear he's working on having a 48-hour-day :wink:

YL
chickens
Regular
Posts: 192
Joined: Wed Dec 06, 2006 12:15 am
Location: Vegas
Contact:

Post by chickens »

yellowled wrote:Actually, Garvin has got the 36-hour-day down, and I hear he's working on having a 48-hour-day :wink:

YL
The question I have is how much caffeine is needed to stay up that long? I've had 24 hours days in the past and it was quite a bit. :shock: <-- I looked like that guy
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Change committed.

And think about Microsoft: I bet they also have some sort of quality control, but still they have to send out patches every week or so ;-)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply