static page plugin

Found a bug? Tell us!!
Post Reply
JWalker
Regular
Posts: 177
Joined: Mon Sep 12, 2005 4:14 pm
Location: Botevgrad, Bulgaria
Contact:

static page plugin

Post by JWalker »

Hi,

(1) It seems that it is not possible to configure the side bar static page plugin not to show a link to the frontpage of the blog. I set $frontpage option to 'true' and to 'false' but the link to the frontpage always is shown. This happens when tree view is configured ($showIcons = true).
When showIcons is false (text-only view), the logic of $frontpage option works well.

(2) If the code controlled by the if operator at line 126 in serendipity_plugin_staticpage.php is not executed, the variable $str remains not initialized and several lines below, at line 137 is used without initialization. Note: I am not fluent in PHP, just think as C/C++ programmer.

Regards,
Ivan Cenov
OKTO-7 Co., Botevgrad
Bulgaria
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: static page plugin

Post by garvinhicking »

Hi!

1.) Yes, the dtree plugin needs to have a fixed "node", a root level element.

2.) That's okay, in PHP you don't need to initialize variables, you can concatenate to an unexisting one. That saves another "else" branch in our case.

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply