downloadmanager path fix (May 17 - made xhtml valid)

[ormus7577]

Hi there,

I've adjusted the downloadmanager plugin, you can now set the http path. This should resolve the missing icons issues on various shared hosting services (like my 1&1 hosting).

For details on what I did read: http://www.ormus.info/archives/16-downl ... ments.html

Any developer with cvs access that would like to check my changes and (in case it's considered useful) commit them?

[garvinhicking]

Hi!

That looks good. Maybe you could offer a unified diff for the patches?

s9y variables can be used in .tpl files! To access those variables, they need to be assigned, though. So if you want to propagate your http-path variable, you must search for the $serendipity['smarty']->assign() calls where the downloadmanager assigns its other variables, and add the http-path variable there.

This would be better for people who are running s9y on sub-paths like /serendipity/, where a URL like /plugins/ would be wrong.

I'd also suggest to use the default variable content in the propbag attribute to use

$serendipity['serendipityHTTPPath'] . 'plugins/serendipity_event_downloadmanager/'

instead.

If all that could be done, I'd love to add it to CVS!

Thanks for your work,
Garvin

[ormus7577]

Thanx for the pointers. I've added your suggestions. I couldn't find a unified diff tool for Win32 though...

You can grab the files here: http://tmp.loben.net/my_download_manager.zip

OT: I like the style of your homepage. I'll keep it in mind, when adjusting the looks of my page.

[garvinhicking]

Hi!

Thanks a lot! Just committed to the official plugin, with 2 minor changes (proper file_exists() check, proper default http location, version bump)

Best regards,
Garvin

[ormus7577]

Another update: I've made the plugin xhtml valid. At least the frontend part of it. Not sure about the backend, but that shouldn't be as bad, because the backend itself is not xhtml valid

Garvin, can you diff the files? I've changed a few and I am not sure, which one I've touched...

http://tmp.loben.net/serendipity_event_ ... anager.zip

[garvinhicking]

Hi!

Great, also committed

Regards,
Garvin