Small bug(?) in serendipity_event_suggest

Creating and modifying plugins.
Post Reply
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Small bug(?) in serendipity_event_suggest

Post by yellowled »

Hey guys,

disclaimer: I don't use serendipity_event_suggest myself, this was reported to me by a user via email. According to this user, the plugin configuration for serendipity_event_suggest does not offer an option to format the page generated by this plugin as an article (yet?), but plugin_suggest.tpl includes the following code:

Code: Select all

{if $plugin_suggest_articleformat}
<div class="serendipity_Entry_Date">
    <h3 class="serendipity_date">{$plugin_suggest_name}</h3>
{/if}
This <div> apparently is never opened since $plugin_suggest_articleformat can't be set in the configuration, but it is closed with a </div> which is not inside an {if}-statement later. This results in a spare </div> which can easily screw up layouts. So this {if}-statement should be commented out until the plugin actually gets that feature.

YL
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Small bug(?) in serendipity_event_suggest

Post by garvinhicking »

Hi!

Ah, great catch. Thanks a lot, just committed a fix.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply