bug with karma

reion · Post by **reion** » Wed Mar 02, 2005 7:53 pm

when i view my index-page, the karma-thing is placed correctly at {$entry.add_footer} ...
but when i go to detailed view (ex. if i have an extended content), the karma thing goes to {$entry.extended}

... is this a bug? ... or is this intention? ... if yes - how can i prevent this?

reion · Post by **reion** » Wed Mar 02, 2005 8:16 pm

wow ... what have i done?!

i have just deinstalled the karma-plugin, and reinstalled it ... now the karma-thing is only shown, when im not in the detailed-mode ... in detailed-mode, it shows nothing - it even doesn't exist ...

...
what's goin' on???

0.8alpha12

Post by **garvinhicking** » Thu Mar 03, 2005 10:45 am

This is intentional behavior of the karma plugin to go into the add_footer only in the entry overview.

About your other issue: If you have the entryproperties plugin used and use caching, you need to refresh your cache for the entries maybe.

Regards,
Garvin

reion · Post by **reion** » Thu Mar 03, 2005 10:58 am

garvinhicking wrote:This is intentional behavior of the karma plugin to go into the add_footer only in the entry overview.

can i change this somehow?

garvinhicking wrote:About your other issue: If you have the entryproperties plugin used and use caching, you need to refresh your cache for the entries maybe.

nope - haven't got this in use ...

Post by **garvinhicking** » Thu Mar 03, 2005 11:49 am

Hi Reion!

reion wrote:
garvinhicking wrote:This is intentional behavior of the karma plugin to go into the add_footer only in the entry overview.
can i change this somehow?

Yes, by modifying the plugins/serendpity_event_karma/serendipity_event_karma.php file. Lines 490-501, 542-617. There you need to change the references to the target fields. It's PHP work and cannot be done easily

garvinhicking wrote:About your other issue: If you have the entryproperties plugin used and use caching, you need to refresh your cache for the entries maybe.

nope - haven't got this in use ...[/quote]

Very strange. What's your URL so I can look at it?

reion · Post by **reion** » Thu Mar 03, 2005 1:14 pm

garvinhicking wrote:Yes, by modifying the plugins/serendpity_event_karma/serendipity_event_karma.php file. Lines 490-501, 542-617. There you need to change the references to the target fields. It's PHP work and cannot be done easily

THANKS ...

garvinhicking wrote:Very strange. What's your URL so I can look at it?

http://www.ksl.mediendesign.eduhi.at/chrism/weblog/

Post by **garvinhicking** » Thu Mar 03, 2005 1:24 pm

Hi!

Hm, this may be a compatibility plugin with others. The entrypaging plugin is one which comes to my mind which could maybe cause the trouble that no karma output is shown on your extended entry view. Can you check if removing that plugin helps?

If not, I could use a full list of your installed event plugins.

Regards,
Garvin

reion · Post by **reion** » Thu Mar 03, 2005 1:26 pm

hallo garvin ... ich schreib das jetzt in deutsch ...

ich hab bei meiner ersten installation das karma gehabt a´parallel mit paging ... da hat's gefunzt ... dann ist mir das aufgefallen, dass das karma irgendwo angezeigt wurde, also hab ichs deinstalliert, wollte es wieder reintun ... und seit dem gehts nicht mehr

hab das paging schon die ganze zeit am laufen

--- hoffentlich ist das wegen dem einen post in deutsch kein problem...

reion · Post by **reion** » Thu Mar 03, 2005 1:27 pm

ok .. i've just deinstalled the paging plugin .. now karma shows up again ... can i change this behaviour too?

#german
kA warum das auf einmal geht, wenn ich paging deaktiviert hab' - vorher gings auch parallel ....

reion · Post by **reion** » Thu Mar 03, 2005 1:30 pm

i'm so sorry, to don't use the edit-function

have a look at this:
http://www.ksl.mediendesign.eduhi.at/ch ... steht.html

i've just kicked paging, and reinstalled it ... now everything works parallel ....
??? why

Post by **garvinhicking** » Thu Mar 03, 2005 2:08 pm

It may have been a problem because the order of event plugins is important and they can affect each other easily.

However I don't really see in which way the plugins could affect each other. I'm sorry - if you find out a further way to reproduce the issue, let me know!

Regards,
Garvin

reion · Post by **reion** » Thu Mar 03, 2005 10:16 pm

garvinhicking wrote:It may have been a problem because the order of event plugins is important and they can affect each other easily.

yes you're right ... if karma is ranked after prev/next-entry, karma doesn't show up in the expanded mode ...

so long ... thanx a lot ...

reion · Post by **reion** » Fri Mar 04, 2005 1:10 am

garvin ... please help me ... i tried to get the karma down to where it shows up in de index page ... but i'm not able to do it ...

i can't see the section, which i should modify ... i have no plan ... please

Post by **garvinhicking** » Fri Mar 04, 2005 12:09 pm

Can'T you just then place the karma plugin before the paging plugin? Just click on the up/down image arrows to move the plugins in the queue, on the Plugin Configuration subpage.

I'll also look and see why/how the plugins affect each other.

Regards,
Garvin

Post by **garvinhicking** » Fri Mar 04, 2005 1:16 pm

Okay, I just fixed the buggy issue.

You can fix it easily by editing your include/plugin_api.inc.php file and go to line #532.

change:

Code: Select all

        $plugins = &serendipity_plugin_api::get_event_plugins();

to tihs:

Code: Select all

        $plugins = serendipity_plugin_api::get_event_plugins();

(Remove the ampersand (&). Then the issue should be fixed. BTW, that one was a very good catch! It seems passing by reference obfuscated the plugin execute command queue, so this wouldn't have been easily noticed.

I did not commit the fix to the current -beta1 release because I first want to see if it has serous side effects (but I can think of none).

Regards,
Garvin