serendipity_event_freetag

[JWalker]

Hi,

When tags are configured to be shown not one per line, there is an extra space ' ' between the tag and the comma ','. So I edited serendipity_event_freetag.php, lines 450 - 452:

Code: Select all

if ($nl) {
    echo '<br />' . "\n";
} else {
    echo ' ';
}

to

Code: Select all

if ($nl) {
    echo '<br />' . "\n";
}

If this is generally accepted, let the developers make the change in CVS...

[garvinhicking]

Hi!

Hm, I think this would have an impact on places where people have not configured to use a comma, then all tags would be added together without any spacing...?!

Regards,
Garvin

[JWalker]

Hi,

The removed space is before the comma, the other one, after the comma is not removed. So it look like this: tag1, tag2, tag3
If someone does not want commas after the tags, he may change line 419

Code: Select all

                echo ', ';

to

Code: Select all

                echo ' ';

Hm, it liked to me, so I removed the commas...

[garvinhicking]

Hi!

Where does that double space happen for you?

In my blog it reads "defined tags for this entry: Tag1, Tag2, Tag3" - do you mean another occurence?

Best regards,
Garin

[JWalker]

Hi,

This is in the side bar, not in/below the entry. It looked so:
tag1 , tag2 , tag3
I removed the space before the comma. Also, I checked, there is no configuration option for this comma. It seems it does not appear when scaling of the tags is turned on --- the condition of the controling if says that at line 418. If it does matter, such config option could be added to the sidebar freetag plugin. The method is

Code: Select all

function displayTags($tags, $xml, $nl, $scaling, $maxSize = 200, $minSize = 100)

[garvinhicking]

Hi!

Argh, okay. I looked in the wrong place. Your suggestion does make sense, I just committed your initial fix

Regards,
Garvin

[ostfriese2004]

Actually, I don't know what you are talking about , but yesterday i upgraded the free tag plugin via sparatcus on my blog resulting in an error message whenever the blogsite was loaded. I had to deinstall the plugin and finally i put the older version online again.

[garvinhicking]

Hi!

Yes there was a temporary bug, but it'S been fixed yesterday or the day before...

Regards,
Garvin