Comments

[jarek]

Hi

during transfer from different blog program to s9y I found in comments a problem. Normally I used to have a title for comments.

1) I found in mysql tables for s9y that "title" possibility too:
table serendipity_comments
title varchar(150)

but in shorter varchar than in "title" entries
serendipity_entries
title varchar(200)

At least I found that this 'title' from 'serendipity_comments' lost in code for comments.

2) I found in serendipity_lang_en.inc.php duplicate definitions like this

Code: Select all

30 @define('NAME', 'Name');
59 @define('NAME', 'Name');

but only first is use by s9y

for example in Polish serendipity_lang_pl.inc.php we have two translation that word, but duplicate constant 'NAME'

Code: Select all

30 @define('NAME', 'Nazwa');
59 @define('NAME', 'Imie');

probably author s9y can kill duplicate definition at line 59.

3) I propose to change a little comments for blog and admin site:
a) by adding in comments formular TITLE (and in lang definition for TITLE) to 5 constants now:
NAME, EMAIL, HOMEPAGE, IN_REPLY_TO, COMMENT

b) by adding in admin site comments formular TITLE to 5 constants now:
ENTRY_TITLE, TIMESTAMP, AUTHOR, IP, EMAIL, URL, REFERER, CONTENT

I think that possibility to entitle comments it will be very useful for commentator, which I know from my old blog site and blogs a friends of mine.

Yours

[garvinhicking]

Hi!

1.) Yes, s9y has no possibility to save titles for comments. We only save titles for trackbacks. So it would need a new feature to supply comments with that title. And many blogs do not use a title so it would need to be optional for existing s9y users...

2.) That is true, thank you. Most of the language files have a duplicate of this sadly - we would need someone who could create a patch file to go through each of the language files, maybe you could create one?

[jarek]

1.) Yes, s9y has no possibility to save titles for comments. We only save titles for trackbacks. So it would need a new feature to supply comments with that title. And many blogs do not use a title so it would need to be optional for existing s9y users...

Yes, it's true rather optional.

2.) we would need someone who could create a patch file to go through each of the language files, maybe you could create one?

I made last saturday patch files with all polish language files from Costa and I sent it to Costa for checking.