Hello, the Gravatar Event Plugin 1.14 has the problem that pickAvatar has a $cache parameter and a $cache static. The later is used for favatars and should be named $cache_dir.
The effect of this is, that gravatars are never cached.
Also: the $cache value should be used for favatars instead of the hardcoded value.
Also: right now gravatar.com is returning images for unknown users with no HTTP error code. I am not sure if that is a temporary problem or intentional. I mailed gravatar owner but did not get feedback.
It is possible to recognize those icons by size and ETag.
Bernd
BTW: the not cache bug is critical - privacy issue.
gravatar event plugin does not cache
-
garvinhicking
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: gravatar event plugin does not cache
Hi!
Thanks for reporting! I'll take care of fixing this next week when I return from a short trip
Regards,
Garvin
Thanks for reporting! I'll take care of fixing this next week when I return from a short trip
Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
ok looks fine
Ok, the diff looks good to me, however I wonder:judebert wrote:eckes, I just commited this to CVS. It looks good to me, but I'd like you to give it a test anyway; I'm worried that the $cache variable will prevent fallback from working properly.
$cache_dir = $serendipity['serendipityPath'] . PATH_SMARTY_COMPILE . '/favatar';
$cache_dir = $serendipity['serendipityPath'] . $serendipity['uploadPath'] . '/gravatar';
Maybe the favatar directory should also be located in the uploadPath?
I am not using the fallback, so i cant really comment on this.
Gruss
Bernd
