New plugin: Mailinglist (Majordomo)

Creating and modifying plugins.
Post Reply
Davy
Regular
Posts: 109
Joined: Fri Oct 13, 2006 2:06 pm
Location: The Netherlands

New plugin: Mailinglist (Majordomo)

Post by Davy »

I built this plugin for my own site, but I think it may be usable for others too.

This plugin lets people subscribe and unsubscribe to a mailinglist based on Majordomo. Because of that, it won't work properly with other lists (e.g. Yahoo! Groups).
Well, actually the plugin works well with all mailinglists that use the body of an email message for the commands.

As anyone can see this is just a tweaked Contact Form, so thanks Garvin for building that!

Download is available at: http://www.davykager.nl/dump/serendipit ... nglist.zip
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: New plugin: Mailinglist (Majordomo)

Post by garvinhicking »

Hi Davy!

Thanks for contributing to serendipity! I had a look at your plugin and I like the intent.

I'd really like to add your functionality, but the problem is that it includes a lot of redundant code (only about 5 lines of code are really changed in comparison to the contactform plugin, plus a new template). So maybe you'd like to instead modify the current contactform plugin and add an option to say "Enable mailinglist-format?" which one can enable. If that option is set, you could use the other mailinglist.tpl file and change the format of the mail; if it is off, it operates as the usual contactform plugin.

Then you also need to modify the language constants to add that the plugin supports majordomo-subscriptions...

How about that, would you like to have a go at it? You have modified your own plugin pretty well, so I am very sure you're capable of it! :-)

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Davy
Regular
Posts: 109
Joined: Fri Oct 13, 2006 2:06 pm
Location: The Netherlands

Post by Davy »

Well, I'm thinking about modifying the plugin more. It should have support for both Yahoo! and Majordomo-lists.
So in the configuration area, you will be able to selct your type of list (using radio buttons).

But maybe it is a good idea to build this in the Contact Form. Or maybe it is useful to include the Mail Entry plugin, so an often discussed problem on this forum is solved. :)
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Count one vote for the Mail Entry plugin! Although, of course, it's really Garvin's vote that counts, since he's the one who has to maintain all this stuff.

One man, one vote. Garvin is the man, and he gets the vote.
Judebert
---
Website | Wishlist | PayPal
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Hm, what I really would feel bad about is duplicate code; if we merge the plugin with the 'Mail Entry' plugin, we would have 80% duplicate code in that plugin and the contact form.

So instead I'd really more like to merge it with the contact form, and then add a notice in the mail entry plugin that tells people that if they have a majordomo running somewhere, they should use the contact form plugin to let people sign up there?

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Davy
Regular
Posts: 109
Joined: Fri Oct 13, 2006 2:06 pm
Location: The Netherlands

Post by Davy »

In a few weeks I'll extend the plugin a bit. So please wait... :)
(However, it sounds good to make a notice in the Mail Entry plugin!)
Post Reply