Updating a comment

Found a bug? Tell us!!
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Updating a comment

Post by Fabien »

If, as an admin, I update the text of a comment from the admin panel, the name and the email address of the author of the comment are automatically changed and replaced by my name and my email address.

A solution?
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Updating a comment

Post by garvinhicking »

Hi!

I think your browser does that; please disable the automatic form input of your browser. If you look at the HTML source code of the page, you should see that the original author name is inserted there.

If its not like that in the HTML, please state your serendipity version and event plugins you are using.

HTH,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: Updating a comment

Post by Fabien »

Hi Garvin,

I don't use the automattic form input function.

"If you look at the HTML source code of the page, you should see that the original author name is inserted there."
Yes the author name and email is correct in the form, but when I press the update button it's my name that is written in the database.

"If its not like that in the HTML, please state your serendipity version and event plugins you are using."
Version 1.
Event plugins: Smilies, CreaticeCommon Licens, Browser compatibility, Spam Protector, User self-registration, Publication rules, NL2BR, BBcode, Extended properties

Thanks a lot, Fabien
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Updating a comment

Post by garvinhicking »

Hi!

Ah! The "User registraion" plugin could be the culprit. Do you have enabled the option "Force user identity"? If that is the case, then even as an admin you cannot currently "fake" another ones identity by editing a comment.

This is because the admin comment form uses the same code than the frontend one.

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: Updating a comment

Post by Fabien »

Hi Garvin,

Alas no. Setting the option to off doesn't solve the problem.

Cheers, Fabien
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Updating a comment

Post by garvinhicking »

Hi!

How exactly did you configure the options of the User Self-Registration sidebar and event plugins?

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: Updating a comment

Post by Fabien »

Hi Garvin,

Sidebar
Add entries forbidden Yes
Publication? Yes
Show sidebar login box? No
Straight insert? No

Event
Only registered users may post comments? Yes
Prevent identity faking No

Best regards, Fabien
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Updating a comment

Post by garvinhicking »

Hi!

Could you tell me which version of the self-registration event plugin you are using? I believe an older version had a bug with the 'identity faking' option...?

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: Updating a comment

Post by Fabien »

Hi Garvin,

Curiously (or not?), the version is not the same for the sidebar, 1.8, and the event plugin, 2.13.

Thanks for your help.
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: Updating a comment

Post by Fabien »

I have seen on the site that there are more recent versions of the plugin. I install them, give a try anf inform you.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Updating a comment

Post by garvinhicking »

Hi!

Ah, that's good. Please upgrade the plugins to their latest versions - either via spartacus or via download from spartacus.s9y.org.

The latest event pluign is 2.18, and I have high hopes that this version fixes your issue. :)

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Solved

Post by Fabien »

Hi Garvin,

The problem is solved with the latest version of the plugin. Thanks a million. Your competency and your availability are a treasure.

"If that is the case, then even as an admin you cannot currently "fake" another ones identity by editing a comment. This is because the admin comment form uses the same code than the frontend one."
Can this be changed in a future version (not an emergency). As an admin, I sometimes correct some mistakes in comments in order to make them more readable or I can suppress sentences that can be offensive. I would like to be able to continue to do that and at the same time use the "Prevent identity faking" option.

Warm regards, Fabien
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Solved

Post by garvinhicking »

Hi Fabien!

Whew. I'm glad we solved this. :-) :-)

About future use: Yes, I believe it a missing feature that as an admin you cannot fake the identity when editing a comment. I will definitely try to patch this after my holidays! If I forget about it, please try to remind me about it. :)

As a temporary workaround you could set the "Prevent" option to "no" before you edit a comment, and then set it back again. Only as a workaround until I get it done. :)

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Post by Fabien »

Hi Garvin,

Holidays are finished... :D
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi Fabien!"

Just as I wanted to implement it, I saw it was already implemented! In version 2.18 of the event adduser plugin it should already be bypassed when the admin edits the commentform?!

It might need a recent s9y version though, which are you running?

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply