plugin erased all my pictures

Found a bug? Tell us!!
Post Reply
robert
Regular
Posts: 1063
Joined: Mon May 09, 2005 9:17 pm
Location: Vienna, Austria
Contact:

plugin erased all my pictures

Post by robert »

I installed the plugin who shows pictures from the mediamanager at a special site. After installing and call the website /pages/gallery.html a long list was shown with deleted pictures.
All my directories (in upload) are still there but with no content.

I think it was the plugin, but I cann´t verify it.
Von 2005 bis 2020 nutzte ich Serendipity/S9y. Auch nach meinem Umstieg bin ich S9y weiterhin in Gedanken verbunden. Ein Dank ergeht an alle Forumsteilnehmer:innen, die mir hier weitergeholfen haben.

Nur ein Blog
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Post by mgroeninger »

Are you talking about the Usergallery plugin?

If so, I doubt it deleted your media. (it doesn't actually touch the database itself.) However, I may have a bug in the newest version.

Or, if you are using 1.1, you may have fallen victim to the new permission system...

Can you check and report back which version you are using?

And if it is 1.1 can you check that you are running a recent snapshot (today's would be good), and check the ACLs on your folders?
robert
Regular
Posts: 1063
Joined: Mon May 09, 2005 9:17 pm
Location: Vienna, Austria
Contact:

Post by robert »

Thanks for replying.

Yes its the usergallery plugin.

I use S9y 1.1. Beta 1.

I uploaded a new picture and the ACL is 664 rw-rw-r-- (similar for the Thumbnail).

Regards
Robert
Von 2005 bis 2020 nutzte ich Serendipity/S9y. Auch nach meinem Umstieg bin ich S9y weiterhin in Gedanken verbunden. Ein Dank ergeht an alle Forumsteilnehmer:innen, die mir hier weitergeholfen haben.

Nur ein Blog
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Post by mgroeninger »

Ok, to use Usergallery with 1.1 you will need to update to a nightly release. I would recommend using the most recent one possible.

The beta releases do not always have functionality which is finished. In this case, Garvin made some changes to the image functions, at my request, during this passed week, to make it easier to code plugins...

The 1.1 compatible Usergallery plugin was add to CVS on Friday morning, just as the (hopefully final) changes to SVN were added to get it to work.

Would you being willing to try to Usergallery plugin with a nightly?
Say "s9y_200608201337.tar.gz" from http://www.s9y.org/12.html?
robert
Regular
Posts: 1063
Joined: Mon May 09, 2005 9:17 pm
Location: Vienna, Austria
Contact:

Post by robert »

I´m a little bit relieved, that it was not my fault and that the bug is detected :)

As I have a full update (thank goodness) of my image directories I could try it again. Not much time this evening, but I try it tomorrow.

Thanks for your help!!!!!
Von 2005 bis 2020 nutzte ich Serendipity/S9y. Auch nach meinem Umstieg bin ich S9y weiterhin in Gedanken verbunden. Ein Dank ergeht an alle Forumsteilnehmer:innen, die mir hier weitergeholfen haben.

Nur ein Blog
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

matthew: The 1.1 code contains automatic "live-synchronizing" of new/missing images, did you already spot that?

It could very well be that your plugin will delete images, if the paths it checks to not really comply. Could you check on that, and maybe add some kind of version check and core patches that are needed? I think the code needs to be changed soon so that no early 1.1 user will loose content!

I'm willing to push 1.1 to 'beta3' if that makes your version detection easier?!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Post by mgroeninger »

matthew: The 1.1 code contains automatic "live-synchronizing" of new/missing images, did you already spot that?
Hmmm... I hadn't spotted that (at least, I haven't seen it in action).

When does the live-sync happen? On a call to serendipity_fetchImagesFromDatabase()? And what do the paths need to look like?

I'll dig around and see what I can find, but that info would help!

Matt
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

It happens in serendipity_displayImageList. Look for "SYNCH" and "onTheFlySynch".

HTH,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Post by mgroeninger »

Ahh... I found it... and I was able to recreate the problem on my test server...

Ok, I will, for now, update the CVS plugin so that the media library view is disabled in 1.1. (The thumbnail view does not call serendipity_displayImageList(), so it shouldn't be affected.)

Edit : I should clearify, the temporary fix is applied to the usergallery plugin, so that the media library view does not call serendipity_displayImageList() in 1.1
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Post by mgroeninger »

Robert,

Thanks for pointing out the bug!!! It is fixed in the current nightly of serendipity core, and the version has been bumped to 1.1-beta3.

The Usergallery plugin, version 1.94 and up, should not cause data loss any longer. However, to use it with 1.1 you will need to be running at least 1.1-beta3 (which current will require you to grab the release from SVN, or wait until tomorrows nightly (s9y_20060822 something...)

Robert, if you would like to try it out again I would love to know how it goes...
robert
Regular
Posts: 1063
Joined: Mon May 09, 2005 9:17 pm
Location: Vienna, Austria
Contact:

Post by robert »

Hi Matt,
it will be a pleasure to make a test :)

But it depends on my spare time - it could last until friday. I will post the results here.

Regards
Robert
Von 2005 bis 2020 nutzte ich Serendipity/S9y. Auch nach meinem Umstieg bin ich S9y weiterhin in Gedanken verbunden. Ein Dank ergeht an alle Forumsteilnehmer:innen, die mir hier weitergeholfen haben.

Nur ein Blog
Post Reply