Here's my Zooomr sidebar plugin

Creating and modifying plugins.
Post Reply
blackmac
Posts: 4
Joined: Thu Aug 03, 2006 4:01 pm

Here's my Zooomr sidebar plugin

Post by blackmac »

Here is a sidebar plugin for displaying the latest pictures from Zooomr feeds (including your own feed).

Check it out:
http://blog.blackmac.de/index.php?/arch ... lugin.html

BlackMac
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Here's my Zooomr sidebar plugin

Post by garvinhicking »

Hi!

Thanks a lot for contributing!

I have two suggestions to make:

1. Instead of using fopen() [which might throw an error when allow_url_fopen is not turned on] you should use the "PEAR HTTP_Request" class. Plugins like Spartacus for example use this to fetch files remotely. Using cURL is also nice, but it's not always available.

2. I suggest you to not create a "getURL" function inside the PHP scope; you should put it into your class to avoid any namespace problems when other plugins would also define such a function.

The rest of the plugin looks very great! I would like to add it to our spartacus repository after the 2 changes, if you like?

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
blackmac
Posts: 4
Joined: Thu Aug 03, 2006 4:01 pm

Re: Here's my Zooomr sidebar plugin

Post by blackmac »

garvinhicking wrote:Hi!
The rest of the plugin looks very great! I would like to add it to our spartacus repository after the 2 changes, if you like?
That would be great. I already updated my download with those two fixes.

Stefan
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Here's my Zooomr sidebar plugin

Post by garvinhicking »

Hi!

Wow, thanks a lot! I just committed it to Spartacus!

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Post by mgroeninger »

Damn, Garvin, you beat me to it...

And you forgot about the unified image sidebar plugin we added a couple of months back...

BlackMac, if you don't mind I would like to roll your plugin into the unified image sidebar plugin (with the changes Garvin suggested, and fully credited to you, of course). You can see what the results look like here: http://beta.theledge.net (Should be identical to yours.)

And you can download a copy of the changes I propose here:
http://www.theledge.net/uploads/serendi ... bar.tar.gz

Basically, the unified image sidebar plugin acts as a wrapper to the other older image sidebar plugins. The hope is that we can eventually remove them from CVS, and cut down on the number of plugins users have to browser through to find what they are looking for. The new sub_plugins themselves are not standard plugins, and do require a little but of modification (changes to function names, etc) but they they are pretty close to the originals (I modified yours to work in about 5 minutes or so...)

So please let me know what you think...
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Ah, dang. I should think about stuff like that. I'm terribly sorry for shooting so fast. I'm sorry :-)

I think it would be very helpful to merge the plugin!

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
blackmac
Posts: 4
Joined: Thu Aug 03, 2006 4:01 pm

Post by blackmac »

Cool!
I was thinking about integrating other services into my plugin, but this is much better.
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Post by mgroeninger »

Cool, your zooomr code has been added to the serendipity_plugin_imagesidebar plugin! (Though I changed the geturl function a bit, so that it will output a generic error message if it fails....)

If you want to add more services to the plugin you should bug Garvin for CVS access! (He'll want to know your sourceforge account to do it.)
blackmac
Posts: 4
Joined: Thu Aug 03, 2006 4:01 pm

Post by blackmac »

mgroeninger wrote:If you want to add more services to the plugin you should bug Garvin for CVS access! (He'll want to know your sourceforge account to do it.)
There's actually only one service i would need (Coppermine remote) missing from the plugin right now and even that is obsolete as I am now moving to a new dedicated server, on which I will run both, my s9s blog and Coppermine. I might implement that plugin anyway, but I'll send a patch when it's done. Thanks
Post Reply