Slight Modification for Windows

[Guest]

Hi,

I think i've got s9y 0.7.1 to run on my windows webserver. In order to get it to work i made the change in index.php to account for the server variables which is documented all over the place in this forum. I also made a slight tweak because it gave a permission error when writing to .htaccess.

I changed line 272 of serendipity_functions_installer.inc.php to:

Code: Select all

        $fp               = @fopen('C:\Domains\xxx.com\wwwroot\blog\.htaccess', 'w');

this made the installation go ok. However, I know little about php so could someone please tell me whether this change is likely to break anything or cuase a huge security hole!

Thanks

[mgroeninger]

You haven't opened up any security holes....

htaccess is a configuration file for apache installs...
serendipity writes to it so that it can configure apache installations correctly...

It looks like all you did was hardcode the file name into the fopen command... since it's in the installer, it wont have any effect on the general running of the server....

I'm not sure why it needed that, though... it should have been able to file as long as the correct path was set in the configuration...

Glad you got it working!!!!!

[Guest]

Just in case its of use to the developers the reason i had to hard code it was because after changeing the line from @fopen to fopen it showed an error saying invalid input or something.
It had the path as c:\blah\blah\/ which i assume was the problem - so i hard coded it without the trailing /. Maybe it was just my server

[garvinhicking]

Okay, so the installer would've been fine if "c:\blah\blah" would have been reported without the trailing "\". If it was "c:\blah\blah/" later on, there wouldn't be a problem.

In current 0.8 version we changed a bit in that area, so maybe your problem shouldn't be there. If it is, we definitely want to fix it.

Regards,
Garvin