Small bug with seo plugin

Found a bug? Tell us!!
Post Reply
Gamersea
Regular
Posts: 65
Joined: Thu Jun 15, 2006 8:52 am

Small bug with seo plugin

Post by Gamersea »

There is a small bug if you don't fill in any description or metatags
bug:
Warning: implode(): Bad arguments. in /You/may/not/see this directory/html/plugins/serendipity_event_metadesc/serendipity_event_metadesc.php on line 109

Edit however I don't know that much of it (yet) but the problem is in this rule:
Code:
$meta_keywords = implode(',', $this->extract_keywords($GLOBALS['entry'][0]['body']));
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Small bug with seo plugin

Post by garvinhicking »

Hi!

Which version of the plugin do you use? I thought this was fixed yesterday.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Gamersea
Regular
Posts: 65
Joined: Thu Jun 15, 2006 8:52 am

Post by Gamersea »

which version? Well I manually updated it with a version of 07/07/2006 I though.
edit: so, version 1.4
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Please tell me the plugin version as shown on the s9y interface; the CVS version string is sadly irrelevant and not so meaningful :)

I just checked the code but I see no way that a "Bad arguemnts" should be returned, because always an array show be returned. :-?

Can you tell me where exactly you see that error? In the backend, or in the frontend?

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Gamersea
Regular
Posts: 65
Joined: Thu Jun 15, 2006 8:52 am

Post by Gamersea »

garvinhicking wrote:Hi!

Please tell me the plugin version as shown on the s9y interface; the CVS version string is sadly irrelevant and not so meaningful :)

I just checked the code but I see no way that a "Bad arguemnts" should be returned, because always an array show be returned. :-?

Can you tell me where exactly you see that error? In the backend, or in the frontend?

Best regards,
Garvin
Frontend I guess it's if you look in the articles the ones where I added a meta description + meta tags there is no error but in the articles where I didn't putted meta tags in (the old articles) they have a error above the header.

below I give you a code where you can see the error!

Code: Select all

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
           "http://www.w3.org/TR/html4/loose.dtd">

<html>
<head>
    <title>All Marketplace Games on the Overview Page  - 360 Marketplace</title>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
    <meta name="Powered-By" content="Serendipity v.1.0" />
    <link rel="stylesheet" type="text/css" href="http://360marketplace.net/index.php?/serendipity.css" />
    <link rel="alternate"  type="application/rss+xml" title="360 Marketplace RSS feed" href="http://360marketplace.net/index.php?/feeds/index.rss2" />
    <link rel="alternate"  type="application/x.atom+xml"  title="360 Marketplace Atom feed"  href="http://360marketplace.net/index.php?/feeds/atom.xml" />

    <link rel="pingback" href="http://360marketplace.net/comment.php?type=pingback&entry_id=11" />

<br />
<b>Warning</b>:  implode(): Bad arguments. in <b>/chroot/home/threesix/360marketplace.net/html/plugins/serendipity_event_metadesc/serendipity_event_metadesc.php</b> on line <b>109</b><br />
  <meta name="description" content="Today we added all the games of the Xbox 360 Marketplace to our " />
  <meta name="keywords" content="" />

</head>

<body>

<div id="serendipity_banner">
    <h1><a class="homelink1" href="http://360marketplace.net/">All Marketplace Games on the Overview Page</a></h1>
    <h2><a class="homelink2" href="http://360marketplace.net/">360 Marketplace</a></h2>
</div>
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Ah, now I got it and fixed it in version 0.3 :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Gamersea
Regular
Posts: 65
Joined: Thu Jun 15, 2006 8:52 am

Post by Gamersea »

jep, I tested it and it works now!

Edit: I got a error on the same place but only if i have in the plugin field the tags: <b></b>

error:
Warning: preg_match_all(): Unknown modifier 'b' in /1/2/3/4/html/plugins/serendipity_event_metadesc/serendipity_event_metadesc.php on line 81

Not a really big problems if I just don't fill in anything there;
HTML Tags for keywords
Enter a comma-separated list of HTML tags that should be searched, which usually contain keywords.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

You must enter "b" in the plugin config, not "<b>". :)

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply