Detail page - entrypaging and tags messed up

Skinning and designing Serendipity (CSS, HTML, Smarty)
Post Reply
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Detail page - entrypaging and tags messed up

Post by yellowled »

Hi everyone,

this is really hard to describe, but I'll try my best :)

In my blog I use a template I made. Pick a random entry and go to the detail (single entry) page (by clicking on the entry title). You'll notice that on the detail page the entrypaging links and tags are displayed right above the entry title, which is not intended. The entry paging links should be above the entry date and the tags in the little box on the left (which actually is the entry footer). And, well, they are.

At least they are in my local s9y installation on my machine at home I use for testing. I have compared (twice, actually) the files in my webspace and on my local machine - they are exactly the same. No differences, no whites spaces or weird characters. However, on my local machine the detail page is displayed correctly and in my webspace it is not. Both the actual and the test blog run on s9y 1.0, the only difference is that my local machine has PHP 4.3.10 and the webspace 4.4.1. Of course this means that both blogs have the same default template files in the template dir.

Any idea how this is possible and how it can be solved? And which .tpl file produces the detail page, is it entries.tpl?

Matthias
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Yes, entries.tpl contains the detail page. You can see what gets processed differently with the $is_single_entry variable.

Examining the source on your blog, there's a </div> closing the EntryFooter just before the div for serendipity_entrypaging. Get rid of that div, and I'll bet your problem will go away.

I'll bet the page won't validate, either.
Judebert
---
Website | Wishlist | PayPal
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

judebert wrote:Examining the source on your blog, there's a </div> closing the EntryFooter just before the div for serendipity_entrypaging. Get rid of that div, and I'll bet your problem will go away.

I'll bet the page won't validate, either.
You're right, it does not validate. The validator actually claims an omitted </div> which should close <div id="mainpane">, but I just now checked my index.tpl. No <div> without a matching </div> in there :)

Scanning the entries.tpl for spare <div>s or </div>s will take some time, but thanks a lot, Jude :)
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Any time. If it turns out to be a problem with one of our standard templates, would you please let us know so we can fix it?

Thanks!
Judebert
---
Website | Wishlist | PayPal
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

judebert wrote:Any time. If it turns out to be a problem with one of our standard templates, would you please let us know so we can fix it?
Of course. Can't imagine it does, however.

I switched the blog back to carl_contest yesterday, looked perfect. It's probably really one lonely </div> somewhere in the entries.tpl I forgot to weed out. This template actually mingles code from carl_contest and ladybug with some ideas by me, I probably got confused somewhere inbetween.

Some time this weekend I'll probably find the time to take a look at it, so expect me to confirm my own mistake or cry for more help on Monday :)
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Check the {foreach} loops in your entries.tpl. I'm quite sure you missed some loop there which then doesn'T validly close the div.

Other thing, some templates mistakenly had <h2>...</div> tags instead of <h2>....</h2>.

HTH,
GArvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

garvinhicking wrote:Check the {foreach} loops in your entries.tpl. I'm quite sure you missed some loop there which then doesn'T validly close the div.

Other thing, some templates mistakenly had <h2>...</div> tags instead of <h2>....</h2>.
Maybe I should watch out for any kind of tag not closed properly ... I tried a new editor for some time which closed tags automatically, maybe that got messed up with me being used to closing tags without help from the editor ...
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

Guys, it keeps being weird.

I fixed it for now. I looked at the differences between my blog and my local machine and realized that the order of the event plugins was different. After adjusting that (actually, pushing the freetag plugin "higher" in the plugin list), at least the tags are now back in the entry footer without changing the .tpl files at all. The entrypaging still doesn't look "right" or like it is on my local machine, but I'm too tired to play around with that more right now :)

Now, is that just a dirty workaround or might that actually be the reason?
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

YellowLed wrote:The entrypaging still doesn't look "right" or like it is on my local machine, but I'm too tired to play around with that more right now :)
Okay, after finishing this posting, I'll try and find a chalkboard somewhere and write "I will check my plugin configuration before making a fuss about template files in the s9y forums next time" a hundred times.

Turns out that I simply had a different setting where to display the entrypaging links in the plugin configuration, so now everything looks fine again, nothing wrong with my template files or those by Carl and Jude I used for mine :)

Anyway, thanks a lot to you guys for helping me clear my mind :oops:
Post Reply