serendipity_rewriteURL bug

Joost · Post by **Joost** » Fri May 26, 2006 6:23 pm

Using version 0.9 but I didnt see any change in 1.0 in this regard.

From functions.entries.inc.php:

if ($serendipity['GET']['page'] > 1) {
$uriArguments = $serendipity['uriArguments'];
$uriArguments[] = 'P'. ($serendipity['GET']['page'] - 1);
$serendipity['smarty']->assign('footer_prev_page', serendipity_rewriteURL(implode('/', $uriArguments) .'.html'));
}

$uriArguments = $serendipity['uriArguments'];
$uriArguments[] = 'P%s';
$serendipity['smarty']->assign('footer_totalEntries', $totalEntries);
$serendipity['smarty']->assign('footer_totalPages', $totalPages);
$serendipity['smarty']->assign('footer_currentPage', $serendipity['GET']['page']);
$serendipity['smarty']->assign('footer_pageLink', serendipity_rewriteURL(implode('/', $uriArguments) . '.html'));
$serendipity['smarty']->assign('footer_info', sprintf(PAGE_BROWSE_ENTRIES, (int)$serendipity['GET']['page'], $totalPages, $totalEntries));

if ($serendipity['GET']['page'] < $totalPages) {
$uriArguments = $serendipity['uriArguments'];
$uriArguments[] = 'P'. ($serendipity['GET']['page'] + 1);
$serendipity['smarty']->assign('footer_next_page', serendipity_rewriteURL(implode('/', $uriArguments) .'.html'));

The following bug/feature happens at:

http://www.tiouw.com/serendipity/

If you look at the next page link it links to: http://www.tiouw.com/serendipity/index. ... es/P2.html

Now if I rename the index.php to nieuws.php as you can see at:

http://www.tiouw.com/serendipity/nieuws.php

the same link has now changed to: http://www.tiouw.com/serendipity/index. ... ws/P2.html

which of course doesnt work.

I understand that its my own fault of changing the name of index.php. But it still seems strange how the functions returns a different URL based on the filename. If you can point me to where I need to look to change this I would be most gratefull.

Post by **garvinhicking** » Fri May 26, 2006 7:00 pm

Change the "indexFile" configuration directive of s9y to adapt the index.php -> nieuws.php change. What you describe is not a bug, because s9y cannot autoguess that you're so evil to rename files without telling s9y.

Regards,
Garvin

Joost · Post by **Joost** » Fri May 26, 2006 9:56 pm

Hi!

Actually you should just use the plugin "Extended properties/templates of Categories" to assign different templates to your categories.

The other way would be to check

Code: Select all

if ($serendipity['GET']['category'] == 'xx') {
serendipity['template'] = 'xx';
} elseif ...

inside your genpage.inc.php.

In either case, you should never need to duplicate index.php files. This is a dead end route you should not follow at all.

HTH & Best regards,
Garvin

Joost · Post by **Joost** » Sat May 27, 2006 7:31 pm

Ok, i'll look into it. Where can I find the plugin? I didnt see it in the repository.

Joost · Post by **Joost** » Sat May 27, 2006 8:56 pm

Ok, I found it. But its too complicated for me to implement. I will now use an additional footer. Very ugly solution but simple and effective.

http://www.tiouw.com/serendipity/cases. ... es/5-Cases

It basically adds a line where it says click here rather than the s9y generated link.

Post by **garvinhicking** » Sat May 27, 2006 10:02 pm

Hi!

What about the plugin is too complicated? I can help you, if you tell me your problems?

The footer link you did IMHO really is a very ugly solution that should not be needed at all.

Best regards,
Garvin

Joost · Post by **Joost** » Sun May 28, 2006 11:13 am

I agree.

What happens is:

1) I activate the Properties/templates for categories plug ins.
2) my templates on the site disappear
3) I go to categories
4) I enter the relevant subdirectory

and nothing happens. It is still lacking the template CSS file.

Post by **garvinhicking** » Sun May 28, 2006 9:30 pm

Hm, which serendipity version are you using? And you are using smarty based templates for your site, right?

Your HTML markup seems quite out of order, it contains double <html> tags. And opening the CSS urL:

http://www.tiouw.com/serendipity/index. ... dipity.css

yields many errors. So there is something generally wrong with your templates, and it just gets obvious when using the plugin...?

Best regards,
Garvin

serendipity_rewriteURL bug

serendipity_rewriteURL bug

Re: serendipity_rewriteURL bug