Small mistake in serendipity_lang_xx.inc.php files

[JWalker]

Hi, there is a mistake in string constants in the language files.
The new introduced constant INSTALL_RSSFETCHLIMIT_DESC has the same value as INSTALL_FETCHLIMIT_DESC.

[judebert]

I'm checking the files, but they look fine: RSSFETCHLIMIT uses "Feeds", while FETCHLIMIT uses "Frontpage". The _DESC files all use "frontend", which is reasonably correct. Which ones did you find the problem with?

Hey, Garvin: if you want me to do the gruntwork of changing the _DESC, let me know what you want. I'm good with vim that way.

[garvinhicking]

Hi judebert!

That would be cool, I suck at bash-level search and replace. Never got that right.

If you could just replace the "Frontpage" with "RSS Feed" int he RSSFETFCHLIMIT_DESC field for all language files, also in the UTF-8 subdir?

And you could even tell me how you did it, if you care to share *g*

Major thanks,
Garvin

[judebert]

It's in SVN.

I keep a list of handy vim commands in $HOME/cmds.vim. My favorites are the regexps. And since vim allows execution of registers, I can edit the buffers however I like until I get it right.

In this case, I added the line

Code: Select all

:%s/\(_RSSFETCHLIMIT_DESC',.*\)frontend/\1RSS Feed/^M

Where ^M is entered with the literal key (ctrl-v on *nix, ctrl-q on Windows) followed by the Enter key. Then I copied the line into register x (my favorite) by pressing "xyy while the cursor was on that line.

Then I went into each file, and typed @x to execute the line, performing the necessary substitution, and used :wn to write it out and move to the next file. 10 minutes or less, all told. Probably could have been done with a sed script, but I'm accustomed to vim.