Bugs: freetag plugin and recent comments plugin

carl_galloway · Post by **carl_galloway** » Tue Jan 10, 2006 11:38 pm

Hi all,

Freetag plugin, not sure if its a bug or feature, but on the startpage the freetag plugin is placed under the entry footer, but in detailed view its above the entry footer. Could this be fixed so it is either above or below on both?

Recent comments plugin, this definitely is a bug, if a comment author is anonynous the plugin leaves a blank space. Could this be fixed?

Cheers
Carl

judebert · Post by **judebert** » Wed Jan 11, 2006 1:44 am

What would you like the anonymous name to be? I'll probably make all blank names the same thing.

Post by **garvinhicking** » Wed Jan 11, 2006 2:03 pm

Carl: Thanks for the freetag pointer. I just committed a new version to CVS (2.33) which should fix that. Can you try it?

Regards,
Garvin

carl_galloway · Post by **carl_galloway** » Wed Jan 11, 2006 5:34 pm

Judebert, anonymous comments in the entry's page are just known as anonymous, I could suggest coward, yellow knees etc, but probably 'anon' would be better. It has the advantage of brevity, and when used in a sidebar or dropdown small is better.

Garvin, awesome, thanks I'll check it out asap.

carl_galloway · Post by **carl_galloway** » Wed Jan 11, 2006 9:59 pm

erm, something went wrong with the comment fix. I've posted a screenshot here. I updated to the latest nightly build, but other than that I'm not using anything else different from the standard installation.

As you can see from the screenshot (bottom of the page), the comments area is being messed around quite badly. This is the detail page for a single entry. The startpage works as per it was before the freetag change.

Cheers
Carl

Post by **garvinhicking** » Thu Jan 12, 2006 11:58 am

Hi Carl!

That error you posted there is impossible to stem from the "recent comments" commit I made.

Does this error happen with the default template, without ANY changes made? Since I can'T reproduce this problem here on my machine...

Regards,
Garvin

judebert · Post by **judebert** » Thu Jan 12, 2006 4:30 pm

To get a default name for anonymous comments, add this code at line 177 of serendipity_plugin_comments.php:

Code: Select all

                $user = trim($user);
                if (empty($user))
                {
                    $user = PLUGIN_COMMENTS_ANONYMOUS;
                }

Then, in the plugin's lang_en.inc.php, add this line:

Code: Select all

@define('PLUGIN_COMMENTS_ANONYMOUS', 'anon');

You can use any string you want, of course, including "yellowbelly". :)

I'll try to commit this to CVS later tonight.

carl_galloway · Post by **carl_galloway** » Thu Jan 12, 2006 5:17 pm

judebert your fix worked like a charm. I would suggest this be 'committed' as a regular part of s9y.

Garvin, I'm sorry, my brain is on overload, I meant the freetag plugin, not the comments plugin - hope this hasn't caused you any headaches.

Carl

Post by **garvinhicking** » Fri Jan 13, 2006 11:31 am

Carl,

thanks for mentioning. I confused the two threads on my own, so it's my fault

I also fixed the plugin in the new version 2.34 now; it was missing the array index "[0]" before "['add_footer']"...

Best regards,
Garvin

carl_galloway · Post by **carl_galloway** » Fri Jan 13, 2006 6:35 pm

Garvin, that worked beautifully (the freetag fix). thank you.

judebert · Post by **judebert** » Sat Jan 14, 2006 8:51 pm

Garvin, I tried to commit my fix at Sourceforge, but the serendipity_plugin_comments is not an additional_plugin. When I checked out the base, I found the existing plugin was only version 1.0, and obviously needed updating. Are we keeping the Serendipity core code elsewhere?

carl_galloway · Post by **carl_galloway** » Sat Jan 14, 2006 9:20 pm

judebert,

the core plugins are hosted at berlios, but I don't know how to access them for your purposes. This linkwill show you what's there.

Carl

judebert · Post by **judebert** » Mon Jan 16, 2006 10:57 pm

Okay, NOW it's in. I hope. I'm new to SVN, but it's very similar to CVS, so everything should have worked out correctly.