Guest Book Plugin

[garvinhicking]

So I guess the wisest thing to do is make the guestbox plugins configuration so that you can define a special email address where mail gets sent to?

Regards,
Garvin

[Wizard]

No, you seem to be missing the point. The already is a configuration option to send an email to the admin.

The guest book plugin is NOT using the configured admin account to send the email notification to. It is using the logged in users email address. In other words it is sending the notification to the same user that wrote the message. That is why it errored off with the user that was not logged in. No email address to send to! I suspect that the users that have it working are not using email notification like I am currently doing until this bug is fixed.

[garvinhicking]

I'm not really missing the point, I'm just thinking on the actual code of the plugin

What the plugin defines as "use admin email" in reality is a "use logged in users email address". In previous s9y versions the $serendipity['email'] address was always set, but when s9y got multiple users, the 'email' variable always containde the value of new users.

Thus it's hard to find the email address of an admin user, when in effect s9y can have multiple admins! Thus I think it's wiser to define the mail that recieves the guestbook entries, right?

Best regards,
Garvin

[Wizard]

Ah, I see. You are right. A specified email address would do the trick. Perhaps in the plugin you should take out the "Send e-mail to admin" option and add a definable email address to receive guest book entries.

[garvinhicking]

Okay, just committed as version 1.32

Regards,
Garvin

[Wizard]

Not sure what's happening, but I can't get the update. I see the upgrade red icon, the log says it's fetching the upgrade files, everthing looks good, no errors. Yet, when I look at my plugin it still states v 1.31 and when I save my Spartacus again (clearing the cache) I can see the upgrade icon again and still it does the same thing. No upgrade. What gives?

[garvinhicking]

Are you maybe using the 0.9 final release? It has a spartacus upgrade problem that is resolved in current nightlies and the 0.9.1 maintenance branch. The 0.9.1 version will be released as soon as I have more time to put a release online and watch some more bugreports.

Regards,
Garvin

[Wizard]

Yeah, I'm using the released version of s9y, 0.9 with PHP 4.3.11. Should I wait? or can I get just the plugin from somewhere else?

[garvinhicking]

Upgrading the plugin only sadly does not help, you also need an upgraded core file. I'd suggest you to use our current nightlies, or fetch the "0.9" branch from SVN to get the upcoming 0.9.1 relase code?!

Regards,
Garvin

[Wizard]

I finally upgraded to the 1.32 plugin, but I'm now getting an error.

Code: Select all

Warning: Missing argument 4 for serendipity_sendmail() in /home/content/html/serendipity/include/functions.inc.php on line 254

Is this what you are talking about where I will need an upgraded core file? Where do I get this file? From which nightly? Or should I get the entire 0.9.1? Perhaps I should wait for the official release of 0.9.1? I guess all I need is the updated functions.inc.php file, but sometimes one file calls another which calls another so an upgrade could be in order.

[garvinhicking]

Oh, that's right, it was a mistake in the guestbook plugin. Go and edit the file and locat ethe serendipity_sendmail() function, and modify it so that the last parameter is "null":

Code: Select all

serendipity_sendMail($target, TEXT_EMAILSUBJECT, sprintf(TEXT_EMAILTEXT,$serendipity['POST']['shoutname'],$serendipity['POST']['shouttext']), null);

The plugin file thing only applied to the new Spartacus version, not related to the guestbook plugin whatsoever

Best regards,
Garvin

[Wizard]

That did it! I guess you can finally call this problem closed! Thanks Garvin.

[garvinhicking]

Glad to have been of help!

Best regards,
Garvin