serendipity_event_xinha bug ?

[Alex22]

Hi,

i noticed may be a bug in serendipity_event_xinha on line 221

Code: Select all

$IMConfig['images_url'] = $serendipity['serendipityHTTPPath'] . '/uploads/';

doesn't seem to return right serendipity http path to 'insert image' xinha plugin because thumbnails don't appear in image select popup and image path is bad [http://uploads/image.thumbnail.jpg]

if i replace live 221 by :

Code: Select all

$IMConfig['images_url'] = 'http://www.mysite.com/uploads/';

then it works

is it a bug ?

thanks for help

Alex

[garvinhicking]

This sounds more like you misconfigure the serendipity paths in your serendipity admin. The "relative path to serendipity" may not ever have a "http://" string in it, and it always need to begin with a "/"!

Please check (or post) your path config, basically you don't need to change that URL setting.

Regards,
Garvin

[Alex22]

This sounds more like you misconfigure the serendipity paths in your serendipity admin. The "relative path to serendipity" may not ever have a "http://" string in it, and it always need to begin with a "/"!

Please check (or post) your path config, basically you don't need to change that URL setting.

Regards,
Garvin

Hi
my relative path to serendipity is '/' automatically set when install.



Thanks for help

Alex

[garvinhicking]

Hhhm...okay, so the images_url key needs to be an absolute URL, not a relative path you're saying? If that is the case, we can patch the plugin to use

$serendipity['baseURL'] instead of $serendipity['serendipityHTTPPath'] and should fix this with that?

Regards,
Garvin

[Guest]

Hhhm...okay, so the images_url key needs to be an absolute URL, not a relative path you're saying? If that is the case, we can patch the plugin to use

$serendipity['baseURL'] instead of $serendipity['serendipityHTTPPath'] and should fix this with that?

Regards,
Garvin

Yes!
but right syntax is

Code: Select all

$IMConfig['images_url'] = $serendipity['baseURL'] . 'uploads/'; 

not

Code: Select all

$IMConfig['images_url'] = $serendipity['baseURL'] . '/uploads/'; 

because $serendipity['baseURL'] already end with /


thanks a lot for help Garvin

Alex

[garvinhicking]

Thanks a lot, I've just committed this fix!

Regards,
Garvin

[MySchizoBuddy]

btw all images need to be absolute once the post is published.
u cannot have relative urls in it right.