blogpdf plugin - bug fix

Creating and modifying plugins.
Post Reply
theseus
Regular
Posts: 41
Joined: Mon Oct 17, 2005 3:40 am

blogpdf plugin - bug fix

Post by theseus »

I have noticed that when you use the blogpdf plugin it runs all the paragraphs together so that your blog looks like one big paragraph.

Would it be possible to have it stick a blank line between each paragraph. In HTML it would be the equivalent of adding a

Code: Select all

<p>
between the paragraphs.

Garvin, I think that that would make this plugin about done except for pictures, which I am sure is a major rewrite, and tweaking to make it work with new versions of Serendipity.

What do you think? Thanks!
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: blogpdf plugin - bug fix

Post by garvinhicking »

The BlogPDF plugin should recognize linebreaks if you entered those as "\n" (carriage return) in your entries, and not just with <p> or <br /> tags.

This means this entry should properly wrap:

Code: Select all

<p>My entry</p>
<p>With some tags</p>
While this entry won't:

Code: Select all

<p>My entry</p><p>With some tags</p>
Can you check that in your entries, if they contain such a linebreak?

PDF does not know about "<p>", they only know "\n". We could transform "</p>" and "<br />" into "\n", but this would double the linebreaks for 99% of how other people usually write entries.

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Guest

Post by Guest »

I know that they don't have \n in them, since it did double my lines... Thanks for explaining!
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

If that doubled your lines it might have been because the nl2br markup plugin was maybe installed twice?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply