Link list plugin

Found a bug? Tell us!!
frodeste
Regular
Posts: 56
Joined: Thu Aug 04, 2005 9:16 pm
Location: Tønsberg, Norway
Contact:

Link list plugin

Post by frodeste »

As far as I can see, this is NOT xhtml 1.1 compliant. I have looked at the code, and only minor changes needs to be adjusted.

Anyone willing to look at this?

-frodeste

EDIT. I'm using the 0.9 last nightly build
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Link list plugin

Post by garvinhicking »

Maybe you can send a patch and we can include it? Or give me the URL to your blog so I can see which errors are caused by it?

(The plugin itself is independent from your core serendipity version)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
frodeste
Regular
Posts: 56
Joined: Thu Aug 04, 2005 9:16 pm
Location: Tønsberg, Norway
Contact:

Re: Link list plugin

Post by frodeste »

www.stenstrom.no

Lets see now:

<h3 class="serendipitySideBarTitle serendipity_plugin_linklist">Linker</h3> <div class="serendipitySideBarContent"><script language="javascript" src="http://www.stenstrom.no/blog/plugin/dtree.js" type="text/javascript"></script><script type="text/javascript">

W3 validator says: "there is no attribute "language" "

Also: target="_blank" is not popular in XHTML 1.1

This is missed by the validator as the statement is d.config.target="_blank";

I don't know what to replace this with.

frode
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Link list plugin

Post by garvinhicking »

Thanks for this pointer. I fixed the javascript thing and only emit the "target" attribute, if it is set. You can't use a different synonym easily instead of TARGET in XHTML...

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
frodeste
Regular
Posts: 56
Joined: Thu Aug 04, 2005 9:16 pm
Location: Tønsberg, Norway
Contact:

Re: Link list plugin

Post by frodeste »

garvinhicking wrote:Thanks for this pointer. I fixed the javascript thing and only emit the "target" attribute, if it is set. You can't use a different synonym easily instead of TARGET in XHTML...

Best regards,
Garvin
So it's not just me then.. I have been looking for a substitute i fot _target in xhtml 1.1, without much success. There's got to be something in the standard for that?!? I have even read most of the docs at www.w3.org.

Anyhow. Congrats on 0.9 release and birthday.

frodeste
frodeste
Regular
Posts: 56
Joined: Thu Aug 04, 2005 9:16 pm
Location: Tønsberg, Norway
Contact:

Re: Link list plugin

Post by frodeste »

garvinhicking wrote:Thanks for this pointer. I fixed the javascript thing and only emit the "target" attribute, if it is set. You can't use a different synonym easily instead of TARGET in XHTML...

Best regards,
Garvin
BTW: This error also applies to the remote RSS/OPML feed sidebar plugin. Y fix?
-- frodeste
www.stenstrom.no
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Link list plugin

Post by garvinhicking »

You can configure the RSS plugin which "target" to use. If you set it empty, it will not appear at all! :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
frodeste
Regular
Posts: 56
Joined: Thu Aug 04, 2005 9:16 pm
Location: Tønsberg, Norway
Contact:

Re: Link list plugin

Post by frodeste »

garvinhicking wrote:You can configure the RSS plugin which "target" to use. If you set it empty, it will not appear at all! :)

Regards,
Garvin
Duh.. Yeah, I see that now. Ask first, think later! Sorry :)

BTW: I can't see the new link list plugin in the daily builds or http://svn.berlios.de/viewcvs/serendipity/ - fixing the xhtml error. (language="javascript" not beeing validated.) Am I missing something?
-- frodeste
www.stenstrom.no
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Link list plugin

Post by garvinhicking »

The linklist plugin is part of our CVS repository, and it's not related to daily builds or SVN...

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
frodeste
Regular
Posts: 56
Joined: Thu Aug 04, 2005 9:16 pm
Location: Tønsberg, Norway
Contact:

Re: Link list plugin

Post by frodeste »

garvinhicking wrote:The linklist plugin is part of our CVS repository, and it's not related to daily builds or SVN...

Regards,
Garvin
But updates are shown on SPARTACUS?
-- frodeste
www.stenstrom.no
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Link list plugin

Post by garvinhicking »

Yes, new plugin versions should be indicated via the spartacus pluginlist!

Here's the commit:

http://cvs.sourceforge.net/viewcvs.py/p ... 1.8&r2=1.9

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
frodeste
Regular
Posts: 56
Joined: Thu Aug 04, 2005 9:16 pm
Location: Tønsberg, Norway
Contact:

Re: Link list plugin

Post by frodeste »

garvinhicking wrote:Yes, new plugin versions should be indicated via the spartacus pluginlist!

Here's the commit:

http://cvs.sourceforge.net/viewcvs.py/p ... 1.8&r2=1.9

Regards,
Garvin
Okey, I see something i not up-to-date on spartacus. You have comitted version 1.6 (revision 1.9), but in the downloaded http://netmirror.org/mirror/serendipity ... bar_no.xml states:

serendipity_plugin_authors/serendipity_plugin_authors.php serendipity_plugin_authors/lang_pt.inc.php serendipity_plugin_authors/lang_de.inc.php serendipity_plugin_authors/UTF-8/lang_pt.inc.php serendipity_plugin_authors/UTF-8/lang_de.inc.php serendipity_plugin_linklist GPL Link List FRONTEND_FEATURES Links manager - Shows your favorite links in the sidebar. Matthew Groeninger, Omid Mottaghi Radlead 1.5 0.8 2005-10-01

And since 1.5 is the versjon I have installed, your excellent update is not distributed. (I have validated it, and it works perfectly! :)

( The alternative mirror: http://s9y.org/mirror//package_sidebar_no.xml is not found.)


Anyhow, I guess you'll look into it, in the mean time, here is another norwegian translation for this plugin (E-mail me to frode@stenstrom.no and I will mail you the translation in reply)
-- frodeste
www.stenstrom.no
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Link list plugin

Post by garvinhicking »

Hi!

When I download this file:

http://netmirror.org/mirror/serendipity ... bar_no.xml

I get version 1.6 listed. Spartacus caches the xml version information (by default) for 24 hours. Did you recently check that file? maybe you change file permissions and the xml file cannot be overwritten?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Post by mgroeninger »

Thanks for taking care of this Garvin!
dma147
Regular
Posts: 132
Joined: Thu Sep 08, 2005 1:50 pm
Location: Berlin
Contact:

Post by dma147 »

I've just fixed the linklist plugin to be absolutly XHTML 1.0 transitional conform. There were mostly the alt="" attribute in the img-tags and the end-tag of <li> missed.

I've comitted this to the s9y-cvs, so it should be available through spartacus within the next 20 hours...

Btw. http://www.validome.org is much more exact than the validator of www.w3c.org. ;) I've used this to validate the linklist plugin.
Alexander Mieland, dma147
http://blog.linux-stats.org
Post Reply