[partly fixed] serendipity_event_entrypaging plugin

Found a bug? Tell us!!
Post Reply
JWalker
Regular
Posts: 177
Joined: Mon Sep 12, 2005 4:14 pm
Location: Botevgrad, Bulgaria
Contact:

[partly fixed] serendipity_event_entrypaging plugin

Post by JWalker »

Several bugs here:

1) The Prev/Next links do not appear anywhere when selected to appear at the bottom of the entry. I tried this with 'sudan' theme and the theme that s9y comes with.

2) Random entry does not appear. It depends on config bool variable 'showrandom' that is fetched from the database (line 164 of serendipity_event_entrypaging.php), but I did not see where it is user-accessible -- even in other parts of s9y.

3) The constant PLUGIN_ENTRYPAGING_BOTTOM is misspelled: PLUGIN_PENTRYPAGING_BOTTOM. This is in lang_de.inc.php and at line 47 of serendipity_event_entrypaging.php.

Now an idea: By now the links for Prev/Next contain the titles of the corresponding entries. I think it will be good idea the user to be allowed to select from these and from standard 'Previous' and 'Next' strings (or even arrows). Whenever, the titles are very long and do not fit on one line.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: serendipity_event_entrypaging plugin

Post by garvinhicking »

Hi!
1) The Prev/Next links do not appear anywhere when selected to appear at the bottom of the entry. I tried this with 'sudan' theme and the theme that s9y comes with.
Hm, this works here properly using serendipity 0.9-beta3 and the default template.

Only since Serendipity 0.8.5 and 0.9-beta2 or so the "bottom" placement should work in the templates. Which version are you using?
2) Random entry does not appear. It depends on config bool variable 'showrandom' that is fetched from the database (line 164 of serendipity_event_entrypaging.php), but I did not see where it is user-accessible -- even in other parts of s9y.
That was a bug. Thanks, fixed. :)
3) The constant PLUGIN_ENTRYPAGING_BOTTOM is misspelled: PLUGIN_PENTRYPAGING_BOTTOM. This is in lang_de.inc.php and at line 47 of serendipity_event_entrypaging.php.
Fixed as well, thanks!
Now an idea: By now the links for Prev/Next contain the titles of the corresponding entries. I think it will be good idea the user to be allowed to select from these and from standard 'Previous' and 'Next' strings (or even arrows). Whenever, the titles are very long and do not fit on one line.
That's a good idea, I've committed customization of the prev/next text as well.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
JWalker
Regular
Posts: 177
Joined: Mon Sep 12, 2005 4:14 pm
Location: Botevgrad, Bulgaria
Contact:

Re: serendipity_event_entrypaging plugin

Post by JWalker »

garvinhicking wrote:Hi!
1) The Prev/Next links do not appear anywhere when selected to appear at the bottom of the entry. I tried this with 'sudan' theme and the theme that s9y comes with.
Hm, this works here properly using serendipity 0.9-beta3 and the default template.

Only since Serendipity 0.8.5 and 0.9-beta2 or so the "bottom" placement should work in the templates. Which version are you using?
I use 0.9beta1. But will wait for official release of 0.9 and will try again then to see what is the matter.
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Perhaps it would be worthwhile to restrict the navigation to the current category, as well?

Or should I implement that with a Smarty-parsed static block?
Post Reply