Hi,
I use the bbcode [ list=i] (no space of course) to add an ordered list in a comment… and I get an unordered list (http://www.chabreuil.com/Aurore/archive ... html#c3045)
An idea?
Thanks,
Fabien
BBCode: ordered list
BBCode: ordered list
Fabien Chabreuil (blog)
Re: BBCode: ordered list
Hi, so instead of the i you wrote a 1?
Re: BBCode: ordered list
Hi,
I think that I have found the problem.
The BBcode plugin uses a class for each type of ordered list: bb-list-ordered-d, bb-list-ordered-lr, bb-list-ordered-ur, bb-list-ordered-la, bb-list-ordered-ua.
But at the end of the plugin, only bb-list-ordered-d, bb-list-ordered-la and bb-list-ordered-ua
If I define bb-list-ordered-lr in my user.css, my list is correctly displayed. It works but it's probably better to add the classes in the plugin.
Have a good day.
Fabien
I think that I have found the problem.
The BBcode plugin uses a class for each type of ordered list: bb-list-ordered-d, bb-list-ordered-lr, bb-list-ordered-ur, bb-list-ordered-la, bb-list-ordered-ua.
But at the end of the plugin, only bb-list-ordered-d, bb-list-ordered-la and bb-list-ordered-ua
If I define bb-list-ordered-lr in my user.css, my list is correctly displayed. It works but it's probably better to add the classes in the plugin.
Have a good day.
Fabien
Fabien Chabreuil (blog)
Re: BBCode: ordered list
Hi,
I have corrected and tested my version of the plugin. Just add after line 300:
Best regards.
I have corrected and tested my version of the plugin. Just add after line 300:
Code: Select all
.bb-list-ordered-lr{
list-style-type:lower-roman
}
.bb-list-ordered-ur{
list-style-type:upper-roman
}
Fabien Chabreuil (blog)
Re: BBCode: ordered list
Great! could you provide a pull request on github, for https://github.com/s9y/Serendipity ?
Re: BBCode: ordered list
I have tried to do it but am not sure it's correct. It's my first use of GitHub.
Fabien Chabreuil (blog)
Re: BBCode: ordered list
Sadly the PR contains a lot of different changes, but not the one wanted.
So the basic workflow: You go to https://github.com/s9y/Serendipity, click on fork (at the top right). Then you clone the new repository to your PC. Make the changes, then git add /file/that/changed, git commit -v and enter a good description, then git push. Then you go back to github to your forked repository and github will offer you to make a Pull Request.
So the basic workflow: You go to https://github.com/s9y/Serendipity, click on fork (at the top right). Then you clone the new repository to your PC. Make the changes, then git add /file/that/changed, git commit -v and enter a good description, then git push. Then you go back to github to your forked repository and github will offer you to make a Pull Request.
Re: BBCode: ordered list
Your change was tested and merged to our master branch. It has also been picked for our next bugfix release.
As the bbcode plugin is packaged with core, your changes won't be available immediately, but will be released with our next bugfix release 2.3.3.
Thank you very much for your work on Serendipity!
As the bbcode plugin is packaged with core, your changes won't be available immediately, but will be released with our next bugfix release 2.3.3.
Thank you very much for your work on Serendipity!