[solved] serendipity_event_statistics - url bug

[konus]

I just found a small bug in serendipity_event_statistics:

In the statistic analysis, reachable via control panel, there is a section "Top Kommentatoren" (top commentors or annotator). If a annotator noted the link to his hompage it is shown like:

Top Kommentatoren
Name (Link)
94 Kommentar(e)

Depending how the annotator entered his link, the resulting link is not correct:

If he entered http://www.annotatorhompage.com without the trailing slash, the link is shown like http://www.myownhomage.de/www.annotatorhompage.com
If he entered http://www.annotatorhompage.com/ with the trailing slash, everything works fine.

[garvinhicking]

Hi!

Thanks for reporting. However I think the problem is not the trailing slash, but rather that the user forgot to add http:// in front of the link. Thus, the link will read "a href='www.blabla'" and that transform to domain.com/www.blabla instead.

I've fixed this in SVN of s9y now.

Regards,
Garvin

[konus]

Hi Garvin, I checked all comments manually, the leading http:// was always there. Putting a / at the end fixed the problem, so I am quit sure about it.

Thank you for fixing it!

[garvinhicking]

Hi!

Hm, if that is so, I did not fix your bug.

Can you post the relevant HTML sourcecode of this portion? I cannot imagine how the trailing "/" should be relevant.

Regards,
Garvin

[konus]

OK, YOU where right. I apologize. In the source code, there are the http:// missing.

I must admit, I did not look into the source code, but in the comments section of the dashboard. However, in the dasboard there seems to be some logic to add a missing http:// transparently. Adding a trailing slash forced the dashboard to save the url-field with the correct heading again and so it looked like to be the problem.

[garvinhicking]

Hi!

Okay, then I'm happy and the fix in the plugin should work properly

Yes, in fact I copied the code that fixes http:// for comments to the plugin

Regards,
Garvin