downloadmanager improvements (collective thread)

[Timbalu]

Hi there

As often reclaimed, the downloadmanager plugin needed a refresh, but nobody really wanted to do it. This is why I started working with it 10 days ago.

We are now heading to version 0.24, which will have some more improvements.

This is what I have done so far:

• 
  in 0.24
  
  - changed frontend templates to be nearly 100% smarty based
  - added new config setting, if the frontend shows its categories and downloads to this blogs registered and logged in users only (default: false) Includes 'dlm_is_registered' in frontend templates.
  - added and changed some backend icons (switched the ugly ones to some famfamfam_silk_icons)
  - added the possibility to clean up the income (ftp/trash) folder immediately via trashbox button
  - changed the usability of the income folder. Now it is used as a trash/temp folder for multiple erased (moved) files also!
  - added a foldable downloadmanager helptip
  - changed and added lang files constants <en>, <de> and <de-utf8>
  - changed arrangement of plugins functions to be more flexible supporting future enhancements
  - changed dlm_functions.js to support mark/unmark functionality
  - added mark and move all selected files in income folder to current folder
  - added mark and erase all selected files in category and move them to the income (ftp/trash) folder to avoid unintentional destroying
  
  0.21 to 0.23.1:
  
  - added root level file appearance in backend (fixed: moved files to root level did not show up) The frontend did/does not show root level files, which isn't really a bug, while it is a feature (by now)
  - changed dlm file work behaviour to support root level files too (please report unusual behaviour)
  - added download file button to backend
  - fixed download of files with spaces in filename to have replaced spaces (_)
  - added style_dlmanager_backend.css
  - added dlm_functions.js - using foldable div containers by now
  - added some missing closing divs - hopefully all of them at the right place
  - changed upload folder to '/serendipity/uploads/.dlmanager/incoming'
  - changed download folder to '/serendipity/templates_c/.dlmanager/files'
  - added missing mkdir of directories using the recursive mkdir function added with PHP 5.0.0
  - fixed is_dir($handle) bug and warning (onli)
  - added style_dlmanager_frontpage.css
  

If you are able to help with code contributions or good advice, please use this thread.
I can not promise to be the one who is the futures maintainer of this plugin, or be the one who will code all your whishes, but maybe we can do it together.

Regards,
Ian

[yellowled]

First of all: It's great that you picked this up. Personally, I still don't see the actual value of this plugin for a blog, but a lot of people want to use it. It's been more or less unmaintained for a long time, so you'll be making a lot of people happy.

Second: 0.24 is not in cvs yet, right? I'm testing 0.23.1 here right now, which kind of throws me off a little since some of the changes you mention for 0.24 are really important in my humble opinion. Let's look at those first:

- changed frontend templates to be nearly 100% smarty based

Woo-hoo! Can't wait to see those. Just in case (no idea if you're already doing this): please use as little inline css as possible, ideally none at all. I will offer some opinion on this.

- added and changed some backend icons (switched the ugly ones to some famfamfam_silk_icons)

Also a great idea, but please don't scale them to fit the old size (famfamfam are 16x16px, right?). If you feel you have to for some reason, don't scale them using the width/height attributes of the img element. (I can help with that if you're not familiar with any graphics application.)

Now for the stuff in 0.23.1:

- added style_dlmanager_backend.css

I haven't really checked it out yet, but I think it needs work. For instance, the upload forms don't really play well with the default admin template right now. They also need proper labels for the form fields. I can help with that too, but I'm going to wait for 0.24 to see if you fixed that yourself already.

- added style_dlmanager_frontpage.css

Will the plugin pick these from a template directory if it exists there (like .tpl files) or will people have to overwrite these styles in the template's stylesheet?

YL

[Timbalu]

First of all: It's great that you picked this up. Personally, I still don't see the actual value of this plugin for a blog, but a lot of people want to use it. It's been more or less unmaintained for a long time, so you'll be making a lot of people happy.

Second: 0.24 is not in cvs yet, right? I'm testing 0.23.1 here right now, which kind of throws me off a little since some of the changes you mention for 0.24 are really important in my humble opinion. Let's look at those first:

Yes, you are right! I am still trying to do some sql optimizing in 0.24, but I got stuck with it today.
Is anybody out there with a very good knowledge of JOINS???

Woo-hoo! Can't wait to see those. Just in case (no idea if you're already doing this): please use as little inline css as possible, ideally none at all. I will offer some opinion on this.

already done, no ones left...

Also a great idea, but please don't scale them to fit the old size (famfamfam are 16x16px, right?). If you feel you have to for some reason, don't scale them using the width/height attributes of the img element. (I can help with that if you're not familiar with any graphics application.)

already done

I haven't really checked it out yet, but I think it needs work. For instance, the upload forms don't really play well with the default admin template right now. They also need proper labels for the form fields. I can help with that too, but I'm going to wait for 0.24 to see if you fixed that yourself already.

there is definitively more in 0.24 but an admin template will have to wait for a later version

- added style_dlmanager_frontpage.css

Will the plugin pick these from a template directory if it exists there (like .tpl files) or will people have to overwrite these styles in the template's stylesheet?

The first, for sure!

Ian

[yellowled]

Great. Unfortunately, I can offer no help at all w/ SQL. So I'll just lean back and wait for 0.24 to land in cvs

YL

[Timbalu]

Hi YL

Are you willing to give it a try, before I release?

I had some constructions in last second and I even had to change the file path settings again. But now, with Garvins help, I found a possible solution for it. Please read the ChangeLog. You may need to upgrade to 0.23.1 before...?!

Ian

[yellowled]

Are you willing to give it a try, before I release?

You can email me a link to a zipfile, but I can't say when I'll be able to get to this. I have quite a share of testing on my plate besides other work currently.

YL

[Timbalu]

I just released the Downloadmanager 0.24 final, which will be available as soon as Garvin will upload it (+ ~ 24 h in Spartacus).

• - added new config setting: 'intro', to have some more introduction text before frontend content (optional)
  - added ics mime icon
  - changed frontend templates, frontend.css and download mime icons to show up refreshed in a new contemporary look (designed by YellowLed, thank you!)
  - changed downloadmanagers file path again to '/serendipty/archives/.dlm/files' and '/serendipty/archives/.dlm/ftpin' which seems to be the best place, dealing with files to come in and go out. The /uploads directory threw a problem with the media library and the /templates_c directory is cleaned up directly by users in some cases. After contacting Garvin about this issues, he came up with the /archives folder. I tried to automate the process of switching all files to the new folders and 0.24s new config settings. I you encounter any problems with it, please move your files manually. If you get a link to inform the plugin, please follow. A next reload will set configs 'chg2archivespath' to true. From now on these directories are not changeable any more and hidden in the downloadmanagers config setting.
  - changed some more plugin cleanup, code optimizing, function sallying
  - changed the frontend files and category templates to be as much smarty based as possible by now
  - added Smarty var 'dlm_is_registered' to all three frontend templates
  - added new config setting, show categories and downloads in frontend to this blogs registered and logged in users only (default: false)
  - added and changed some backend icons (switched the ugly ones to some famfamfam_silk_icons)
  - changed the frontend.css and backend.css files to support multiple html code changes, which still is a work in progress
  - added the possibility to clean up the income (ftp/trash) folder immediately via trashbox button
  - changed the usability of income folder. Now it is used as a trash/temp folder for multiple erased (moved) files also!
  - added a foldable downloadmanager helptip
  - changed and added lang files constants <en>, <de> and <de-utf8>
  - changed arrangement of plugins functions to be more clear and flexible and to support future enhancements
  - changed dlm_functions.js to support mark/unmark functionality
  - added mark and move all selected files in income folder to current folder
  - added mark and erase all selected files in category and move them to the income (ftp/trash) folder to avoid unintentional destroying

ToDo v.0.25:
- a backend template
- and/or ? ? ?, please report here

Regards
Ian

[yellowled]

ToDo v.0.25:
- a backend template

Let's just call that "backend interface improvements". I already have various ideas for that. (Or did you want to smartify the plugin's backend? Is that even possible?!)

YL

[Timbalu]

Let's just call that "backend interface improvements". I already have various ideas for that. (Or did you want to smartify the plugin's backend? Is that even possible?!)

I hope so!
But really, not today!
I'll send you an inviting mail when I arrived there.

Ian

[Timbalu]

Hi

I am coming close to the stretch with 0.25...
If anybody wants an enhancement or a new feature, now is the time to bark!

Regards,
Ian

[Timbalu]

Well, you had your chance...!
Version 0.25 now is released and will be available through Spartacus around tomorrow..

Shortened ChangeLog:
- changed some frontend tpls and lang files
- changed new backend templates and stylesheet under the hood (based and designed by YellowLed)
- changed root level db setting to be unhidden by now
- added rename file ability in backends single file edit page
- added new s9y media library import icon
- added a complete smarty template to backend, which caused multiple changes in plugins code

Regards,
Ian

edit:
I am sorry for the delay, but it seems Garvin has a free weekend, so we have to rest in patience!

[Timbalu]

I released an update to the Downloadmanager v.0.25, available by now, which will mainly remove the deprecation warnings in PHP 5.3.3, regarding this thread http://board.s9y.org/viewtopic.php?f=4&t=17054 .

Regards
Ian